From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/9] ps3: AV Settings Driver Date: Tue, 30 Jan 2007 01:16:57 +0100 Message-ID: <200701300116.57606.arnd@arndb.de> References: <200701260513.24010.arnd@arndb.de> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1HBggg-0006bK-Pn for linux-fbdev-devel@lists.sourceforge.net; Mon, 29 Jan 2007 16:17:27 -0800 Received: from moutng.kundenserver.de ([212.227.126.186]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1HBggf-00011C-5H for linux-fbdev-devel@lists.sourceforge.net; Mon, 29 Jan 2007 16:17:26 -0800 In-Reply-To: Content-Disposition: inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Geert Uytterhoeven Cc: linuxppc-dev@ozlabs.org, James Simmons , Linux Frame Buffer Device Development , Paul Mackerras On Monday 29 January 2007 16:14, Geert Uytterhoeven wrote: > > > You should probably use the provided pr_debug or (better) dev_dbg > > macros to do that now. > > Except that it's difficult to get a struct device * in drivers/ps3/ps3av_cmd.c. > And I prefer not to make ps3av_dev (which is currently static) global. Ok, as I said, dev_dbg is the preferred way, but of course it only works when you carry a device along. If you don't have one, use pr_debug(). Arnd <>< ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186]) by ozlabs.org (Postfix) with ESMTP id 7AAC2DDE33 for ; Tue, 30 Jan 2007 11:17:16 +1100 (EST) From: Arnd Bergmann To: Geert Uytterhoeven Subject: Re: [PATCH 1/9] ps3: AV Settings Driver Date: Tue, 30 Jan 2007 01:16:57 +0100 References: <200701260513.24010.arnd@arndb.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200701300116.57606.arnd@arndb.de> Cc: linuxppc-dev@ozlabs.org, James Simmons , Linux Frame Buffer Device Development , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Monday 29 January 2007 16:14, Geert Uytterhoeven wrote: > > > You should probably use the provided pr_debug or (better) dev_dbg > > macros to do that now. > > Except that it's difficult to get a struct device * in drivers/ps3/ps3av_cmd.c. > And I prefer not to make ps3av_dev (which is currently static) global. Ok, as I said, dev_dbg is the preferred way, but of course it only works when you carry a device along. If you don't have one, use pr_debug(). Arnd <><