From: Andrew Morton <akpm@osdl.org>
To: "Frédéric Riss" <frederic.riss@gmail.com>,
"Matt Domsch" <Matt_Domsch@dell.com>
Cc: linux-kernel@vger.kernel.org, artiom.myaskouvskey@intel.com,
bjorn.helgaas@hp.com,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] EFI x86: pass firmware call parameters on the stack
Date: Tue, 30 Jan 2007 11:10:58 -0800 [thread overview]
Message-ID: <20070130111058.db191e07.akpm@osdl.org> (raw)
In-Reply-To: <1170183678.21603.73.camel@funkylaptop>
On Tue, 30 Jan 2007 20:01:18 +0100
Frédéric Riss <frederic.riss@gmail.com> wrote:
>
> When calling into an EFI firmware, the parameters need to be passed on
> the stack. The recent change to use -mregparm=3 breaks x86 EFI support.
> This patch is needed to allow the new Intel-based Macs to suspend to ram
> when run in EFI mode (efi.get_time is called during the suspend phase).
>
> Signed-off-by: Frederic Riss <frederic.riss@gmail.com>
>
> ---
>
> [As I couldn't find an official maintainer for the linux/efi.h file and
> the file header is quite old, I'm Cc:ing the last 2 commiters.]
Matt normally looks after EFI.
> This patch fixes the issue for x86, but the file is also used by IA64. I
> would have used asmlinkage to force arguments on the stack, but it has a
> special meaning on IA64, thus I used a raw regparm(0) GCC attribute.
> This attribute is documented only for x86, I hope it has no side effect
> on other archs.
hm, this sounds like a fairly serious problem. Has this been runtime
tested on ia64 and x86_64>
next prev parent reply other threads:[~2007-01-30 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 19:01 [PATCH] EFI x86: pass firmware call parameters on the stack Frédéric Riss
2007-01-30 19:10 ` Andrew Morton [this message]
2007-01-30 19:16 ` Frédéric Riss
2007-01-30 19:17 ` Bjorn Helgaas
2007-01-30 20:41 ` Frédéric Riss
2007-02-01 2:32 ` bibo,mao
2007-02-01 8:10 ` Frederic Riss
2007-02-02 1:32 ` bibo,mao
-- strict thread matches above, loose matches on Subject: below --
2007-01-30 20:16 Matt Domsch
2007-01-31 19:46 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070130111058.db191e07.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Matt_Domsch@dell.com \
--cc=artiom.myaskouvskey@intel.com \
--cc=bjorn.helgaas@hp.com \
--cc=frederic.riss@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.