All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: Reducing warning output from pci_get_subsys()
Date: Tue, 30 Jan 2007 22:12:53 -0800	[thread overview]
Message-ID: <20070131061253.GA2638@kroah.com> (raw)
In-Reply-To: <6543410C-B60C-4706-AB4E-FA64C4E592F5@kernel.crashing.org>

On Tue, Jan 30, 2007 at 11:18:21PM -0600, Kumar Gala wrote:
> 
> On Jan 30, 2007, at 11:11 PM, Andrew Morton wrote:
> 
> >On Tue, 30 Jan 2007 22:55:38 -0600 (CST)
> >Kumar Gala <galak@kernel.crashing.org> wrote:
> >
> >>Greg,
> >>
> >>There was some code added to warn if pci_get_subsys() is called  
> >>and the
> >>pci_devices is empty.
> >>
> >>I'm wondering if there is some point at which we know its ok for the
> >>pci_devices list be empty if there are no devices on the bus so we  
> >>can
> >>stop printing the message.
> >>
> >>On an embedded PPC reference system I see this message 6 times  
> >>when I've
> >>got no cards in the PCI slots.
> >>
> >
> >I'd suggest we just remove the warning.  Also the one in  
> >pci_find_subsys().
> >
> >I let them go through because I was curious to know what would  
> >cause it to
> >trigger - it might be an indication of other bugs.  But nothing very
> >interesting happened and they're of no use.
> 
> Works for me.

No objection from me either.

thanks,

greg k-h

      reply	other threads:[~2007-01-31  6:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-31  4:55 Reducing warning output from pci_get_subsys() Kumar Gala
2007-01-31  5:11 ` Andrew Morton
2007-01-31  5:18   ` Kumar Gala
2007-01-31  6:12     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070131061253.GA2638@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=galak@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.