All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: olof@lixom.net (Olof Johansson)
Cc: jgarzik@pobox.com, netdev@vger.kernel.org,
	Francois Romieu <romieu@fr.zoreil.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] [v3] PA Semi PWRficient Ethernet driver
Date: Wed, 31 Jan 2007 10:38:06 -0800	[thread overview]
Message-ID: <20070131103806.29fc8d2e@freekitty> (raw)
In-Reply-To: <20070131054457.GA32043@lixom.net>

O
> +static noinline void pasemi_mac_free_tx_resources(struct net_device *dev)

Why tell compiler how to do it's job.  marking it noinline?

> Index: merge/drivers/net/pasemi_mac.h
> ===================================================================
> --- /dev/null
> +++ merge/drivers/net/pasemi_mac.h
					 PAS_IOB_DMA_COM_TIMEOUTCFG_TCNT_M)
> +
> +struct pas_dma_xct_descr {
> +	union {
> + 		u64	mactx;
> +#define	XCT_MACTX_T		0x8000000000000000
> +#define	XCT_MACTX_ST		0x4000000000000000
> +#define XCT_MACTX_NORES		0x0000000000000000
> +#define XCT_MACTX_8BRES		0x1000000000000000
> +#define XCT_MACTX_24BRES	0x2000000000000000
> +#define XCT_MACTX_40BRES	0x3000000000000000
> +#define XCT_MACTX_I		0x0800000000000000
> +#define XCT_MACTX_O		0x0400000000000000
> +#define XCT_MACTX_E		0x0200000000000000
> +#define XCT_MACTX_VLAN_M	0x0180000000000000
> +#define XCT_MACTX_VLAN_NOP	0x0000000000000000
> +#define XCT_MACTX_VLAN_REMOVE	0x0080000000000000
> +#define XCT_MACTX_VLAN_INSERT   0x0100000000000000
> +#define XCT_MACTX_VLAN_REPLACE  0x0180000000000000
> +#define XCT_MACTX_CRC_M		0x0060000000000000
> +#define XCT_MACTX_CRC_NOP	0x0000000000000000
> +#define XCT_MACTX_CRC_INSERT	0x0020000000000000
> +#define XCT_MACTX_CRC_PAD	0x0040000000000000
> +#define XCT_MACTX_CRC_REPLACE	0x0060000000000000
> +#define XCT_MACTX_SS		0x0010000000000000
> +#define XCT_MACTX_LLEN_M	0x00007fff00000000
> +#define XCT_MACTX_LLEN_S	32ull
> +#define XCT_MACTX_LLEN(x)	((((long)(x)) << XCT_MACTX_LLEN_S) & XCT_MACTX_LLEN_M)
> +#define XCT_MACTX_IPH_M		0x00000000f8000000
> +#define XCT_MACTX_IPH_S		27ull
> +#define XCT_MACTX_IPH(x)	((((long)(x)) << XCT_MACTX_IPH_S) & XCT_MACTX_IPH_M)
> +#define XCT_MACTX_IPO_M		0x0000000007c00000
> +#define XCT_MACTX_IPO_S		22ull
> +#define XCT_MACTX_IPO(x)	((((long)(x)) << XCT_MACTX_IPO_S) & XCT_MACTX_IPO_M)
> +#define XCT_MACTX_CSUM_M	0x0000000000000060
> +#define XCT_MACTX_CSUM_NOP	0x0000000000000000
> +#define XCT_MACTX_CSUM_TCP	0x0000000000000040
> +#define XCT_MACTX_CSUM_UDP	0x0000000000000060
> +#define XCT_MACTX_V6		0x0000000000000010
> +#define XCT_MACTX_C		0x0000000000000004
> +#define XCT_MACTX_AL2		0x0000000000000002
> +		u64	macrx;

Mixing definitions and structure values gets confusing.

-- 
Stephen Hemminger <shemminger@linux-foundation.org>

  parent reply	other threads:[~2007-01-31 18:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-29  6:08 [PATCH] PA Semi PWRficient Ethernet driver Olof Johansson
2007-01-29 18:22 ` Stephen Hemminger
2007-01-30  1:41   ` Olof Johansson
2007-01-30  2:34     ` Jeff Garzik
2007-01-30 20:53       ` Olof Johansson
2007-01-29 22:35 ` Francois Romieu
2007-01-30  1:41   ` Olof Johansson
2007-01-30 10:06     ` Christoph Hellwig
2007-01-30 15:34       ` Olof Johansson
2007-01-30 21:45     ` Francois Romieu
2007-01-31  4:52       ` Olof Johansson
2007-01-30  1:44 ` [PATCH] [v2]PA " Olof Johansson
2007-01-31  5:44   ` [PATCH] [v3] PA " Olof Johansson
2007-01-31 10:34     ` Jeff Garzik
2007-02-01  3:40       ` Olof Johansson
2007-01-31 12:44     ` Ingo Oeser
2007-01-31 15:16       ` Olof Johansson
2007-01-31 18:38     ` Stephen Hemminger [this message]
2007-02-01  3:20       ` Olof Johansson
2007-02-01  3:43     ` [PATCH] [v4] " Olof Johansson
2007-02-02 13:26       ` Jeff Garzik
2007-01-30 10:03 ` [PATCH] " Christoph Hellwig
2007-01-30 15:36   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070131103806.29fc8d2e@freekitty \
    --to=shemminger@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.