All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <syrjala@sci.fi>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Petr Vandrovec <petr@vandrovec.name>, jsimmons@infradead.org
Subject: Re: [PATCH] matroxfb: another attempt to rectify jitter (G450/G550)
Date: Wed, 31 Jan 2007 13:54:30 +0200	[thread overview]
Message-ID: <20070131115430.GB5039@sci.fi> (raw)
In-Reply-To: <45BFA90D.5050207@us.ibm.com>

On Tue, Jan 30, 2007 at 02:22:37PM -0600, Paul A. Clarke wrote:
snip...
> +				/* DVI PLL preferred for frequencies up to panellink max, standard PLL
> otherwise */
> +				if (fout >= MINFO->max_pixel_clock_panellink) tmp = 0;
> +				else tmp =
> +					M1064_XDVICLKCTRL_DVIDATAPATHSEL |
> +					M1064_XDVICLKCTRL_C1DVICLKSEL |
> +					M1064_XDVICLKCTRL_C1DVICLKEN |

Shouldn't this check which CRTC is driving the DVI?

> +					M1064_XDVICLKCTRL_DVILOOPCTL |
> +					M1064_XDVICLKCTRL_P1LOOPBWDTCTL;
> +				matroxfb_DAC_out(PMINFO M1064_XDVICLKCTRL,tmp);
>    				matroxfb_DAC_out(PMINFO M1064_XPWRCTRL, xpwrctrl);
> 
>    				matroxfb_DAC_unlock_irqrestore(flags);
> 

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

  reply	other threads:[~2007-01-31 11:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-23  0:17 [PATCH] matroxfb: another attempt to rectify jitter (G450/G550) Paul A. Clarke
     [not found] ` <45BC58E9.9020306@vandrovec.name>
2007-01-30 20:22   ` Paul A. Clarke
2007-01-31 11:54     ` Ville Syrjälä [this message]
2007-01-31 21:58       ` Paul A. Clarke
2007-01-31 22:25         ` Ville Syrjälä
2007-02-15 20:47           ` Paul A. Clarke
2007-02-16 17:29             ` Ville Syrjälä
2007-02-17  6:34               ` Petr Vandrovec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070131115430.GB5039@sci.fi \
    --to=syrjala@sci.fi \
    --cc=jsimmons@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=petr@vandrovec.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.