All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Matthias Lederhofer <matled@gmx.net>
Cc: git@vger.kernel.org
Subject: Re: git repack -a -d is not safe
Date: Thu, 1 Feb 2007 15:59:34 -0500	[thread overview]
Message-ID: <20070201205934.GA19057@spearce.org> (raw)
In-Reply-To: <20070201112545.GA19855@moooo.ath.cx>

Matthias Lederhofer <matled@gmx.net> wrote:
> First the object is unpacked, start something using read_sha1_file.
> read_sha1_file: try packed object (fails)
> run git repack -a -d
> read_sha1_file: try to read the loose object (fails)
> read_sha1_file: reread list of packs
> run git repack -a -d so it will create a new pack
> read_sha1_file: tries to open the old packs, not the new one, and
>                 fails

My 4 patch series that I just posted should (partially) fix this
problem.  We cannot close it completely however as there always
exists the potential of the OS to starve the reader and allow 2
full repacks between the time the reader notices a .idx file and
the time the reader could open the .pack.

At least now with my additional changes Git will report that a
packfile is not usable, and then that the object cannot be found,
and die.

All I can say is, wait at least a few minutes between repacks?  ;-)

-- 
Shawn.

  reply	other threads:[~2007-02-01 20:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-01 11:25 git repack -a -d is not safe Matthias Lederhofer
2007-02-01 20:59 ` Shawn O. Pearce [this message]
2007-02-01 23:26   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070201205934.GA19057@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=matled@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.