From: Ivo van Doorn <ivdoorn@gmail.com>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Jiri Benc <jbenc@suse.cz>,
"John Linville" <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] d80211-p54: Add control structure for beacontemplates
Date: Sat, 3 Feb 2007 17:40:30 +0100 [thread overview]
Message-ID: <200702031740.30569.IvDoorn@gmail.com> (raw)
In-Reply-To: <200702031133.52203.flamingice@sourmilk.net>
On Saturday 03 February 2007 17:33, Michael Wu wrote:
> On Saturday 03 February 2007 11:25, Ivo van Doorn wrote:
> > p54 seems to ignore the beacon that is being passed,
> > even though it is requesting the BEACON_TEMPLATE.
> > That is why I not only added a line to free the control structure
> > but also the beacon itself.
> >
> Yeah, beacons aren't actually handled yet. BEACON_TEMPLATE can just be turned
> off for now if it's causing problems, though I don't see a reason why a
> beacon would be generated for managed mode.
It would only be generated for AP mode.
In any case, the new patch:
Signed-off-by Ivo van Doorn <IvDoorn@gmail.com>
---
diff --git a/drivers/net/wireless/d80211/p54/prism54common.c b/drivers/net/wireless/d80211/p54/prism54common.c
index fd4ea5d..8335f99 100644
--- a/drivers/net/wireless/d80211/p54/prism54common.c
+++ b/drivers/net/wireless/d80211/p54/prism54common.c
@@ -766,8 +766,7 @@ struct ieee80211_hw *p54_init_common(size_t priv_data_len)
priv->modes[0].rates = priv->rates;
priv->modes[0].num_channels = ARRAY_SIZE(p54_channels);
priv->modes[0].channels = priv->channels;
- dev->flags = IEEE80211_HW_HOST_GEN_BEACON_TEMPLATE |
- IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING | /* not sure */
+ dev->flags = IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING | /* not sure */
IEEE80211_HW_RX_INCLUDES_FCS |
IEEE80211_HW_WEP_INCLUDE_IV |
IEEE80211_HW_DATA_NULLFUNC_ACK; /* TODO: check */
next prev parent reply other threads:[~2007-02-03 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-03 16:25 [PATCH 3/3] d80211-p54: Add control structure for beacontemplates Ivo van Doorn
2007-02-03 16:33 ` Michael Wu
2007-02-03 16:40 ` Ivo van Doorn [this message]
2007-02-03 16:49 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702031740.30569.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.