From: Alan <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Tejun Heo <htejun@gmail.com>, Allen Martin <AMartin@nvidia.com>,
linux-ide@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Nvidia cable detection problems (was [PATCH] amd74xx: don't configure udma mode higher than BIOS did)
Date: Mon, 5 Feb 2007 22:02:32 +0000 [thread overview]
Message-ID: <20070205220232.3e73297b@localhost.localdomain> (raw)
In-Reply-To: <58cb370e0702051327p7b253dafs439c937093ca837d@mail.gmail.com>
> Since we are already using UDMA mode set by BIOS to determine if 80c cable
> is present so why not also use it to determine if the 40c cable is present?
>
> I mean just ignoring AMD_CABLE_DETECT register for NVIDIA devices.
>
> 2-lines change and we wouldn't have to deal with ACPI at ell.
And as I explained earlier you get false values. The existing hack is
dodgy as well and breaks on suspend/resume then loading the driver for
one. It's probably the best that can be done without ACPI but the ACPI
_GTM/_STM methods are pretty clean so its not hard to use them. You need
them for full suspend/resume support anyway.
Alan
next prev parent reply other threads:[~2007-02-05 21:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 7:58 [PATCH] amd74xx: don't configure udma mode higher than BIOS did Tejun Heo
2007-02-05 11:24 ` Alan
2007-02-05 12:16 ` Tejun Heo
2007-02-05 12:33 ` Tejun Heo
2007-02-05 13:24 ` Alan
2007-02-05 14:17 ` Tejun Heo
2007-02-05 13:22 ` Alan
2007-02-05 14:07 ` Tejun Heo
2007-02-05 14:34 ` Nvidia cable detection problems (was [PATCH] amd74xx: don't configure udma mode higher than BIOS did) Alan
2007-02-05 14:50 ` Tejun Heo
2007-02-05 15:49 ` Alan
[not found] ` <58cb370e0702050709w1b7682dr5dff9e7ce69465a@mail.gmail.com>
2007-02-05 17:08 ` Allen Martin
2007-02-05 17:08 ` Allen Martin
2007-02-05 18:12 ` Alan
2007-02-05 18:12 ` Alan
2007-02-05 18:36 ` Tejun Heo
2007-02-05 18:55 ` Bartlomiej Zolnierkiewicz
2007-02-05 19:15 ` Tejun Heo
2007-02-05 21:27 ` Bartlomiej Zolnierkiewicz
2007-02-05 22:02 ` Alan [this message]
2007-02-05 22:00 ` Bartlomiej Zolnierkiewicz
2007-02-05 19:13 ` Alan
2007-02-05 21:43 ` Jeff Garzik
2007-02-05 21:11 ` Nvidia cable detection problems & ACPI (beware, slight off-top) Oleg Verych
2007-02-05 22:04 ` Alan
2007-02-05 21:55 ` Jeff Garzik
2007-02-05 22:42 ` Oleg Verych
2007-02-05 22:51 ` Jeff Garzik
2007-02-05 15:32 ` [PATCH] amd74xx: don't configure udma mode higher than BIOS did Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070205220232.3e73297b@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=AMartin@nvidia.com \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.