From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, kaber@trash.net, dipankar@in.ibm.com,
paulmck@us.ibm.com
Subject: Re: [patch 11/11] netfilter warning fix
Date: Tue, 6 Feb 2007 13:34:01 +0100 [thread overview]
Message-ID: <20070206123401.GA8052@elte.hu> (raw)
In-Reply-To: <20070205185324.16b54b64.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Mon, 05 Feb 2007 18:44:08 -0800 (PST) David Miller
> <davem@davemloft.net> wrote:
>
> > I bet this rcu_read_lock()-implies-preempt_disable() assumption has
> > spread into other areas of the tree as well.
>
> Me too. Although one expects that other holes will cause might_sleep
> or lockdep warnings pretty easily.
>
> Still, life is hard enough as it is. I think I'll shelve rcu-preempt
> pending resolution of this.
that was pretty much the only place in the whole kernel that got hit by
some rcu-preempt side-effect - and even this appears to show that it's a
real bug that was in hiding. So please dont shelve RCU-preempt for this
reason :-)
Ingo
next prev parent reply other threads:[~2007-02-06 12:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 0:31 [patch 11/11] netfilter warning fix akpm
2007-02-06 2:10 ` David Miller
2007-02-06 2:18 ` Andrew Morton
2007-02-06 2:44 ` David Miller
2007-02-06 2:53 ` Andrew Morton
2007-02-06 12:34 ` Ingo Molnar [this message]
2007-02-06 19:43 ` David Miller
2007-02-06 21:02 ` Ingo Molnar
2007-02-06 21:23 ` David Miller
2007-02-06 21:58 ` Ingo Molnar
2007-02-07 6:43 ` Patrick McHardy
2007-02-07 8:07 ` Ingo Molnar
2007-02-07 8:13 ` David Miller
2007-02-07 8:16 ` Patrick McHardy
2007-02-07 8:18 ` Ingo Molnar
2007-02-06 9:21 ` Martin Josefsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070206123401.GA8052@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dipankar@in.ibm.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.