From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 3/4] PS3: Fix DMA scatter-gather
Date: Tue, 6 Feb 2007 14:22:26 +0100 [thread overview]
Message-ID: <200702061422.26578.arnd@arndb.de> (raw)
In-Reply-To: <45BFD2C2.70000@am.sony.com>
On Wednesday 31 January 2007 00:20, Geoff Levand wrote:
> @@ -272,10 +272,29 @@ static void ps3_unmap_single(struct devi
> =A0static int ps3_map_sg(struct device *_dev, struct scatterlist *sg, int=
nents,
> =A0=A0=A0=A0=A0=A0=A0=A0enum dma_data_direction direction)
> =A0{
> +=A0=A0=A0=A0=A0=A0=A0struct ps3_system_bus_device *dev =3D to_ps3_system=
_bus_device(_dev);
> +=A0=A0=A0=A0=A0=A0=A0int i;
> +
> =A0#if defined(CONFIG_PS3_DYNAMIC_DMA)
> =A0=A0=A0=A0=A0=A0=A0=A0BUG_ON("do");
> +=A0=A0=A0=A0=A0=A0=A0return -EPERM;
> +#else
Do you still need the #ifdef? Since there is no point executing this,
would guess you can just as well keep only the other version, right?
Arnd <><
next prev parent reply other threads:[~2007-02-06 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 23:20 [PATCH 3/4] PS3: Fix DMA scatter-gather Geoff Levand
2007-02-06 13:22 ` Arnd Bergmann [this message]
2007-02-06 16:43 ` Geoff Levand
2007-02-07 0:42 ` Benjamin Herrenschmidt
2007-02-07 7:43 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702061422.26578.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.