From: Andrew Morton <akpm@linux-foundation.org>
To: Ken Chen <kenchen@google.com>
Cc: linux-mm@kvack.org
Subject: Re: hugetlb: preserve hugetlb pte dirty state
Date: Tue, 6 Feb 2007 16:35:31 -0800 [thread overview]
Message-ID: <20070206163531.8d524171.akpm@linux-foundation.org> (raw)
In-Reply-To: <b040c32a0702061306l771d2b71s719cee7cf4713e71@mail.gmail.com>
On Tue, 6 Feb 2007 13:06:39 -0800
"Ken Chen" <kenchen@google.com> wrote:
> --- ./mm/hugetlb.c.orig 2007-02-06 08:28:33.000000000 -0800
> +++ ./mm/hugetlb.c 2007-02-06 08:29:47.000000000 -0800
> @@ -389,6 +389,8 @@
> continue;
>
> page = pte_page(pte);
> + if (pte_dirty(pte))
> + set_page_dirty(page);
> list_add(&page->lru, &page_list);
> }
> spin_unlock(&mm->page_table_lock);
I guess we really should be setting these pages dirty at fault-time, as we're
now doing with regular pages.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-02-07 0:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 21:06 hugetlb: preserve hugetlb pte dirty state Ken Chen
2007-02-06 21:36 ` Nish Aravamudan
2007-02-06 21:43 ` Ken Chen
2007-02-07 0:35 ` Andrew Morton [this message]
2007-02-07 0:47 ` Ken Chen
2007-02-07 1:08 ` Andrew Morton
2007-02-07 1:22 ` Ken Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070206163531.8d524171.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kenchen@google.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.