From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [patch] pvfb: Split mouse and keyboard into separate devices. Date: Wed, 7 Feb 2007 14:36:48 +0000 Message-ID: <20070207143648.GA26258@redhat.com> References: <45C9B880.5060107@suse.de> <877iuu2g5f.fsf@pike.pond.sub.org> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <877iuu2g5f.fsf@pike.pond.sub.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Markus Armbruster Cc: Gerd Hoffmann , Xen devel list List-Id: xen-devel@lists.xenproject.org On Wed, Feb 07, 2007 at 03:31:24PM +0100, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > Hi, > > > > This patch creates two separate input devices for keyboard and mouse > > events. Also includes some key bitmap fixes (allow all keyboard keys, > > allow eight mouse buttons). > > > > I hope everyone is happy with that now after the lengthy discussion ;) > > > > please apply, > > Gerd > > > > -- > > Gerd Hoffmann > > pvfb: Split mouse and keyboard into separate devices. > > > > This patch creates two separate input devices for keyboard and mouse > > events. The reason for this is to separate them in the linux input > > layer and allow them being routed different ways. > > > > Use case: Configure the X-Server like this to get the mouse > > events directly from the linux input layer, which has the major > > advantage that absolute coordinates work correctly: > > > > Section "InputDevice" > > Driver "evdev" > > Identifier "Mouse" > > Option "Device" "/dev/input/event" > > EndSection > > > > This makes the keyboard stop working though in case mouse and > > keyboard events are coming through the same input device, at least > > with older Xorg (6.9) versions. > > > > Signed-off-by: Gerd Hoffmann > > New, not mentioned in the changelog: > > * Initialization of struct input_dev members phys, id.bustype, > id.vendor, id.product. > > * Take care of the FIXME regarding initialization struct input_dev > member keybit (thanks!). > > * Take care of the TODO to enable all pointer buttons. Perhaps should > better go in together with the fix to tools/xenfb/vncfb.c posted by > Daniel. Yep, the kernel portion of my patches are obsoleted by Gerd's updated patch. The userspace portion still needs applying. I've no objections to Gerd's patch being applied. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|