diff for duplicates of <20070208073649.GA1751@ff.dom.local> diff --git a/a/1.txt b/N1/1.txt index 53afb5c..78f6f66 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,13 +20,13 @@ etc. 2c: it is a question of taste, but here: > err = -ENOBUFS; ->+ if (q->classes[HTB_CLS_ARRAY(minorid)] = NULL) { +>+ if (q->classes[HTB_CLS_ARRAY(minorid)] == NULL) { >+ if ((q->classes[HTB_CLS_ARRAY(minorid)] = >+ kzalloc(sizeof(htb_cls_array), GFP_KERNEL)) ->+ = NULL) +>+ == NULL) >+ goto failure; >+ } -> if ((cl = kzalloc(sizeof(*cl), GFP_KERNEL)) = NULL) +> if ((cl = kzalloc(sizeof(*cl), GFP_KERNEL)) == NULL) > goto failure; it would be probably more readable and a bit merciful @@ -36,8 +36,4 @@ the last error (I know it's not a leak). Regards, Jarek P. -PS: 1c extra - it's easier to read a diff if you use -p option. -_______________________________________________ -LARTC mailing list -LARTC@mailman.ds9a.nl -http://mailman.ds9a.nl/cgi-bin/mailman/listinfo/lartc +PS: 1c extra - it's easier to read a diff if you use -p option. diff --git a/a/content_digest b/N1/content_digest index ccd424f..37cca07 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\020070205101637.GB1863@ff.dom.local\0" "ref\0200702051814.13899.simonl@parknet.dk\0" "From\0Jarek Poplawski <jarkao2@o2.pl>\0" - "Subject\0[LARTC] Re: [PATCH] HTB O(1) class lookup\0" - "Date\0Thu, 08 Feb 2007 07:36:49 +0000\0" + "Subject\0Re: [PATCH] HTB O(1) class lookup\0" + "Date\0Thu, 8 Feb 2007 08:36:49 +0100\0" "To\0Simon Lodal <simonl@parknet.dk>\0" "Cc\0Andi Kleen <ak@suse.de>" Patrick McHardy <kaber@trash.net> @@ -33,13 +33,13 @@ "2c: it is a question of taste, but here:\n" "\n" "> \t\terr = -ENOBUFS;\n" - ">+\t\tif (q->classes[HTB_CLS_ARRAY(minorid)] = NULL) {\n" + ">+\t\tif (q->classes[HTB_CLS_ARRAY(minorid)] == NULL) {\n" ">+\t\t\tif ((q->classes[HTB_CLS_ARRAY(minorid)] = \n" ">+\t\t\t kzalloc(sizeof(htb_cls_array), GFP_KERNEL))\n" - ">+\t\t\t = NULL)\n" + ">+\t\t\t == NULL)\n" ">+\t\t\t\tgoto failure;\n" ">+\t\t}\n" - "> \t\tif ((cl = kzalloc(sizeof(*cl), GFP_KERNEL)) = NULL)\n" + "> \t\tif ((cl = kzalloc(sizeof(*cl), GFP_KERNEL)) == NULL)\n" "> \t\t\tgoto failure;\n" "\n" "it would be probably more readable and a bit merciful\n" @@ -49,10 +49,6 @@ "Regards,\n" "Jarek P.\n" "\n" - "PS: 1c extra - it's easier to read a diff if you use -p option. \n" - "_______________________________________________\n" - "LARTC mailing list\n" - "LARTC@mailman.ds9a.nl\n" - http://mailman.ds9a.nl/cgi-bin/mailman/listinfo/lartc + PS: 1c extra - it's easier to read a diff if you use -p option. -410a68e0a7af42f3394d1f0363d23a9142ea585094cde65ab994c54bae5da01f +42238675be68ec7e4b0fdacf9d0177352e3b235b6515095d1959f5a986128cc9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.