From: Michael Buesch <mb@bu3sch.de>
To: "Gary Zambrano" <zambrano@broadcom.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH review] b44: Port to ssb subsystem
Date: Thu, 8 Feb 2007 16:02:11 +0100 [thread overview]
Message-ID: <200702081602.11679.mb@bu3sch.de> (raw)
In-Reply-To: <1170887802.15655.14.camel@dhcp-10-7-81-58.broadcom.com>
On Wednesday 07 February 2007 23:36, Gary Zambrano wrote:
> On Tue, 2007-01-23 at 17:20 +0100, Michael Buesch wrote:
> > This patch ports b44 to the new SSB subsystem and makes
> > it possible to turn off PCI related stuff.
> >
> > This patch is against my tree, where I have implemented the
> > ssb subsystem.
> >
> > If you're all OK with this patch, I'd like apply it to my tree.
> > I think that's best. Although it's not wireless-related, it's
> > much easier to maintain this way.
>
> >
> > +static int b44_ethtool_ioctl (struct net_device *dev, void __user *useraddr)
>
> Michael, Do you really want to create ethtool_ioctl() to do what the
> ethtool_ops does?
No, that was bogus code that slipped in by accident.
I merged a fixed version of this into my tree:
http://bu3sch.de/gitweb?p=wireless-dev.git;a=commitdiff;h=461bce2df6da451ba0e4b532e67c02ea5284300f
--
Greetings Michael.
prev parent reply other threads:[~2007-02-08 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 16:20 [PATCH review] b44: Port to ssb subsystem Michael Buesch
2007-02-07 22:36 ` Gary Zambrano
2007-02-08 15:02 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702081602.11679.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.