From: Imre Deak <imre.deak@solidboot.com>
To: rmk@arm.linux.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] DEV: zero: use correct pgprot for zeromapping
Date: Sat, 10 Feb 2007 12:03:40 +0200 [thread overview]
Message-ID: <20070210100340.GA7519@bitbox.mine.nu> (raw)
In-Reply-To: <20070210093954.GA29145@flint.arm.linux.org.uk>
On Sat, Feb 10, 2007 at 09:39:54AM +0000, Russell King wrote:
> On Sat, Feb 10, 2007 at 11:15:21AM +0200, Imre Deak wrote:
> > Instead of PAGE_COPY use the pgprot bits established already at
> > original mapping time of the VMA. This will also include any
> > architecture specific bits setup through protection_map.
> > zeromap_page_range will take care of COW'ing the passed pgprot.
>
> NAK. What if PAGE_COPY is used elsewhere and ends up accidentally
> allowing write access?
Or rather, result in the bogus global mapping. True.
>
> I think the right solution is to make PAGE_COPY a variable in the same
> way that PAGE_KERNEL is, and adjust it as appropriate.
Ok, and also at least PAGE_SHARED and PAGE_READONLY I assume.
--Imre
next prev parent reply other threads:[~2007-02-10 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-10 9:15 [PATCH] DEV: zero: use correct pgprot for zeromapping Imre Deak
2007-02-10 9:39 ` Russell King
2007-02-10 10:03 ` Imre Deak [this message]
2007-02-10 17:29 ` [PATCH] ARM: VM: fix user page protection values (was Re: [PATCH] DEV: zero: use correct pgprot for zeromapping) Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070210100340.GA7519@bitbox.mine.nu \
--to=imre.deak@solidboot.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.