All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Tejun Heo <htejun@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Jeff Garzik <jgarzik@pobox.com>,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [patch] linux/io.h: forward declare struct pci_dev
Date: Sat, 10 Feb 2007 22:55:11 -0800	[thread overview]
Message-ID: <20070210225511.384f894b.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20070211063431.GS10050@ftp.linux.org.uk>

On Sun, 11 Feb 2007 06:34:31 +0000 Al Viro wrote:

> My current version:
> 
> >From 97f115834b5ebef4f04e0f18aaa10f78f43733a0 Mon Sep 17 00:00:00 2001
> From: Al Viro <viro@zeniv.linux.org.uk>
> Date: Sat, 10 Feb 2007 23:41:09 -0500
> Subject: [PATCH] sort the devres mess out
> 
> Split the implementation-agnostic stuff in separate files.
> Make sure that targets using non-default request_irq() pull kernel/irq/devres.o
> Mark targets that have no ioport_map() and friends, protect the ioport-related
> Parts of lib/devres.o with corresponding ifdef (BTW, we need it in driver
> dependencies in quite a few of cases, so that symbol was needed anyway).
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 1523046..7215152 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -29,6 +29,10 @@ config MMU
>  	bool
>  	default y
>  
> +config NO_IOPORT
> +	bool
> +	default n

Uh, I think that we would rather see a positive-sense symbol instead
of a negative one.  Any reason that this one prefers to be negative?

Thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  parent reply	other threads:[~2007-02-11  6:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-10 11:45 [patch] linux/io.h: forward declare struct pci_dev Heiko Carstens
2007-02-11  3:49 ` Christoph Hellwig
2007-02-11  6:26   ` Tejun Heo
2007-02-11  6:34     ` Al Viro
2007-02-11  6:46       ` Tejun Heo
2007-02-11  6:55       ` Randy Dunlap [this message]
2007-02-11  7:10       ` Christoph Hellwig
2007-02-11  8:21         ` Al Viro
2007-02-11 15:09       ` Jeff Garzik
2007-02-11 15:31       ` Heiko Carstens
2007-02-11 15:41         ` [PATCH] sort the devres mess out Al Viro
2007-02-11 15:49           ` Jeff Garzik
2007-02-11 22:16             ` Roland Dreier
2007-02-12  5:30               ` [PATCH] ia64: Fix noncoherent DMA API so devres builds Roland Dreier
2007-02-12 21:06                 ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070210225511.384f894b.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.