From: Andrew Morton <akpm@linux-foundation.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: ricknu-0@student.ltu.se, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean-values
Date: Mon, 12 Feb 2007 12:27:38 -0800 [thread overview]
Message-ID: <20070212122738.b5e9a8af.akpm@linux-foundation.org> (raw)
In-Reply-To: <1171132062.3373.31.camel@mulgrave.il.steeleye.com>
> On Sat, 10 Feb 2007 12:27:42 -0600 James Bottomley <James.Bottomley@SteelEye.com> wrote:
> When discussion about TRUE and FALSE came up a long time a go in the
> context of the mid layer we agreed to strip the defined constants out of
> that code and just go with 1 and 0 inline ... because the code was
> pretty much being rewritten. We also decided to encourage but not force
> the driver writers simply to use 1 and 0 as well ... a lot of people are
> deeply wedded to the TRUE and FALSE defines, it turned out.
Given that we now have a standard kernel-wide, c99-friendly way of
expressing true and false, I'd suggest that this decision can be revisited.
Because a "true" is significantly more meaningful (and hence readable)
thing than a bare "1".
next prev parent reply other threads:[~2007-02-12 20:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-10 17:46 [PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean-values Richard Knutsson
2007-02-10 18:27 ` James Bottomley
2007-02-10 20:35 ` Richard Knutsson
2007-02-10 20:43 ` Richard Knutsson
2007-02-12 20:27 ` Andrew Morton [this message]
2007-02-16 16:42 ` James Bottomley
2007-02-16 18:04 ` Richard Knutsson
2007-02-16 18:23 ` James Bottomley
2007-02-16 19:10 ` Richard Knutsson
2007-02-16 18:34 ` Andrew Morton
2007-02-16 18:42 ` James Bottomley
2007-02-16 18:50 ` Andrew Morton
2007-02-16 21:43 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070212122738.b5e9a8af.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.