From: Al Viro <viro@ftp.linux.org.uk>
To: "Amit S. Kale" <amitkale@netxen.com>
Cc: netdev@vger.kernel.org, jeff@garzik.org,
netxenproj@linsyssoft.com, rob@netxen.com
Subject: Re: [PATCH 1/1] NetXen: Fix to get the driver working after sparse changes
Date: Mon, 12 Feb 2007 22:40:58 +0000 [thread overview]
Message-ID: <20070212224058.GE4095@ftp.linux.org.uk> (raw)
In-Reply-To: <200702121233.l1CCXcZ7024013@dut39.unminc.com>
On Mon, Feb 12, 2007 at 04:33:38AM -0800, Amit S. Kale wrote:
> Signed-off-by: Amit S. Kale <amitkale@netxen.com>
ACK. My apologies - that pile of brainos had been introduced when
I'd been fixing the set_bit() abuses in there (a bunch of places
had been casting address of u32 to unsigned long * and then using
set_bit() to modify it). FWIW, it had nothing to do with sparse -
just enough RTFS to spot the original bug and not enough of
RTFPatch to spot the introduced breakage. Sorry.
next prev parent reply other threads:[~2007-02-12 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 12:33 [PATCH 1/1] NetXen: Fix to get the driver working after sparse changes Amit S. Kale
2007-02-12 22:40 ` Al Viro [this message]
2007-02-17 20:26 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070212224058.GE4095@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=amitkale@netxen.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=netxenproj@linsyssoft.com \
--cc=rob@netxen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.