All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: "Tomas Winkler" <tomasw@gmail.com>
Cc: "Jouni Malinen" <jkm@devicescape.com>,
	"Jiri Benc" <jbenc@suse.cz>,
	linux-wireless@vger.kernel.org
Subject: Re: d80211: current TKIP hwcrypto implementation seems to be broken
Date: Tue, 13 Feb 2007 01:33:11 +0100	[thread overview]
Message-ID: <200702130133.11690.mb@bu3sch.de> (raw)
In-Reply-To: <1ba2fa240702121619x259f546dga2bebefbe24bf1d3@mail.gmail.com>

On Tuesday 13 February 2007 01:19, Tomas Winkler wrote:
> > HW doesn't scramble it. So when d80211 receives the packet it can
> > _then_ generate the key. There's no point in precomputing it.
> 
> For past packets you've already computed it so why do  it again? So
> you keep 2 phas1 keys one old and one current. When sequence numbers
> advance sufficiently you discard the old one and compute the new one
> in a spare time. Something like double buffer.

Ah, now I see. We are talking about two different things.
You are talking about the TX key and I am talking about
the RX key. We could probably cache the TX key to avoid the
key computation on every TX. That's right. But I don't even have
it working, yet, so optimization is not my worry, yet. :)
But yes, that could be an optimization to be done.

-- 
Greetings Michael.

  parent reply	other threads:[~2007-02-13  0:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-04 12:44 d80211: current TKIP hwcrypto implementation seems to be broken Michael Buesch
2007-02-05 20:43 ` Jiri Benc
2007-02-05 21:38   ` Johannes Berg
2007-02-05 21:45     ` Johannes Berg
2007-02-05 21:48       ` Johannes Berg
2007-02-06 14:55   ` Michael Buesch
2007-02-12 18:30 ` Jouni Malinen
2007-02-12 21:39   ` Michael Buesch
2007-02-12 23:15     ` Tomas Winkler
2007-02-12 23:23       ` Michael Buesch
2007-02-12 23:54         ` Tomas Winkler
2007-02-13  0:10           ` Michael Buesch
2007-02-13  0:19             ` Tomas Winkler
2007-02-13  0:28               ` Jouni Malinen
2007-02-13  1:08                 ` Tomas Winkler
2007-02-13  1:20                   ` Jouni Malinen
2007-02-15 16:58                     ` Tomas Winkler
2007-02-13  0:33               ` Michael Buesch [this message]
2007-02-13  1:09                 ` Tomas Winkler
2007-02-12 23:53     ` Jouni Malinen
2007-02-13  0:06       ` Michael Buesch
2007-02-13  0:16         ` Michael Buesch
2007-02-13 16:18   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702130133.11690.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=jbenc@suse.cz \
    --cc=jkm@devicescape.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.