From: Andi Kleen <andi@firstfloor.org>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: "Jeff Dike" <jdike@addtoit.com>,
linux-kernel@vger.kernel.org, patches@x86-64.org
Subject: Re: [patches] [PATCH 2.6.21 review I] [4/25] x86: kernel-mode faults pollute current->thead
Date: Tue, 13 Feb 2007 11:00:25 +0100 [thread overview]
Message-ID: <200702131100.25829.andi@firstfloor.org> (raw)
In-Reply-To: <45D17C66.76E4.0078.0@novell.com>
On Tuesday 13 February 2007 08:52, Jan Beulich wrote:
> >Yup. How does this patch look to you? We set error_code and trap_no
> >for userspace faults and kernel faults which call die(). We don't set
> >them for kernelspace faults which are fixed up.
>
> Actually, after a second round of thinking I believe there's still more to do
> - your second patch missed fixing i386's do_trap() similarly to x86-64's
> and, vice versa, x86-64's do_general_protection() similarly to i386's.
I dropped the patch for now until that is all worked out
-Andi
next prev parent reply other threads:[~2007-02-13 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 7:52 [patches] [PATCH 2.6.21 review I] [4/25] x86: kernel-mode faults pollute current->thead Jan Beulich
2007-02-13 10:00 ` Andi Kleen [this message]
2007-02-14 17:51 ` Jeff Dike
2007-02-15 8:01 ` Jan Beulich
2007-02-15 16:23 ` Jeff Dike
-- strict thread matches above, loose matches on Subject: below --
2007-02-10 11:50 [PATCH 2.6.21 review I] [1/25] x86_64: Add __copy_from_user_nocache Andi Kleen
2007-02-10 11:50 ` [PATCH 2.6.21 review I] [4/25] x86: kernel-mode faults pollute current->thead Andi Kleen
2007-02-12 9:32 ` [patches] " Jan Beulich
2007-02-12 16:42 ` Jeff Dike
2007-02-12 17:01 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702131100.25829.andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=jbeulich@novell.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@x86-64.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.