From: Ralf Baechle <ralf@linux-mips.org>
To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: More __get_user_asm_ll32 ...
Date: Tue, 13 Feb 2007 13:32:51 +0000 [thread overview]
Message-ID: <20070213133251.GA7518@linux-mips.org> (raw)
__get_user_asm_ll32 contains a junk move %0, $0 left over from an older
version of the code. Ignoring fixups code and data this instruction
inflates the normal path in __get_user() by 50% which may explain much of
the size and performance you have meassures. It also always clears
the error return, iow. __get_user_asm_ll32(..., &<something 64-bit>)
would never have returned an error. ARGH.
Ralf
next reply other threads:[~2007-02-13 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 13:32 Ralf Baechle [this message]
2007-02-13 16:06 ` More __get_user_asm_ll32 Atsushi Nemoto
2007-02-13 16:11 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070213133251.GA7518@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.