All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Eric Van Hensbergen <ericvh@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	v9fs-developer@lists.sourceforge.net, ericvh@gmail.com
Subject: Re: [RESEND][PATCH] 9p: add write-cache support to loose cache mode
Date: Tue, 13 Feb 2007 16:27:42 -0800	[thread overview]
Message-ID: <20070213162742.2fb1fa06.akpm@linux-foundation.org> (raw)
In-Reply-To: <11714109311262-git-send-email-ericvh@gmail.com>

> On Tue, 13 Feb 2007 17:55:31 -0600 Eric Van Hensbergen <ericvh@gmail.com> wrote:
> +static ssize_t
> +v9fs_file_write(struct file *filp, const char __user * data,
> +		size_t count, loff_t * offset)
> +{
> +	struct inode *inode = filp->f_path.dentry->d_inode;
> +
> +	ssize_t ret;
> +
> +	dprintk(DEBUG_VFS, "count %d offset %x\n", 
> +			(int)count, (int)*offset);
> +	ret = v9fs_write(filp, data, NULL, count, offset);
> +	invalidate_inode_pages2(inode->i_mapping);
> +	return ret;
> +}
> +

invalidate_inode_pages2() can fail.  It might be worth at least warning here
if it does.

      parent reply	other threads:[~2007-02-14  0:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-13 23:55 [RESEND][PATCH] 9p: add write-cache support to loose cache mode Eric Van Hensbergen
2007-02-14  0:16 ` Andrew Morton
2007-02-14  2:07   ` Eric Van Hensbergen
2007-02-14  2:11     ` Andrew Morton
2007-02-14  3:05       ` Nick Piggin
2007-02-14  3:10         ` Andrew Morton
2007-02-14  0:26 ` Andrew Morton
2007-02-14  0:27 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070213162742.2fb1fa06.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ericvh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.