All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@in.ibm.com>
To: linux kernel mailing list <linux-kernel@vger.kernel.org>
Cc: kraxel@suse.de, Andi Kleen <ak@muc.de>
Subject: Will smp alternative try to patch init text also?
Date: Wed, 14 Feb 2007 16:13:39 +0530	[thread overview]
Message-ID: <20070214104338.GA3393@in.ibm.com> (raw)

Hi,

I just built a 2.6.20 kernel with CONFIG_RELOCATABLE=y. While going
through relocation entries for .smp_locks section, I see some relocation
entries present w.r.t to init section also. Below I am pasting just
few of them.

Relocation section '.rel.smp_locks' at offset 0x6079c8 contains 4662 entries:
 Offset     Info    Type            Sym.Value  Sym. Name
c058e000  00001201 R_386_32          c0593000   .init.text
c058e004  00001201 R_386_32          c0593000   .init.text
c058e008  00001201 R_386_32          c0593000   .init.text

So what happens if somebody builds a SMP kernel and runs on a UP machine.
Later it hotplus one CPU. Then kernel will switch to SMP mode. Looking
at the code it looks like it will also try to patch init text which is
no more there and will corrupt something else? 

Am I missing something?

MODPOST whitelists the references from .smp_locks section to .init.text,
hence these warnings are not displayed during compilation.

Thanks
Vivek

             reply	other threads:[~2007-02-14 10:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 10:43 Vivek Goyal [this message]
2007-02-14 10:51 ` Will smp alternative try to patch init text also? Gerd Hoffmann
2007-02-14 11:12   ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070214104338.GA3393@in.ibm.com \
    --to=vgoyal@in.ibm.com \
    --cc=ak@muc.de \
    --cc=kraxel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.