Re: [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c

[Srivatsa Vaddagiri <vatsa@in.ibm.com>]

On Wed, Feb 14, 2007 at 08:13:05PM +0530, Gautham R Shenoy wrote:
> +	switch (action) {
> +	case CPU_UP_PREPARE:
> +		/* Create a new workqueue thread for it. */
> +		list_for_each_entry(wq, &workqueues, list) {

Its probably safe to take the workqueue (spin) lock here (and other
notifiers as well), before traversing the list.

> +			cwq = per_cpu_ptr(wq->cpu_wq, hotcpu);
> +			if (create_workqueue_thread(cwq, hotcpu)) {
> +				printk("workqueue for %i failed\n", hotcpu);
> +				return NOTIFY_BAD;
> +			}
> +		}
> +		break;

-- 
Regards,
vatsa