From: Len Brown <lenb@kernel.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-acpi@vger.kernel.org, akpm <akpm@osdl.org>
Subject: Re: [PATCH] ACPI: use NULL for ptrs
Date: Wed, 14 Feb 2007 18:17:55 -0500 [thread overview]
Message-ID: <200702141817.55746.lenb@kernel.org> (raw)
In-Reply-To: <20070213161136.e8c8ac5b.randy.dunlap@oracle.com>
Applied.
thanks,
-Len
On Tuesday 13 February 2007 19:11, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix sparse warnings in ACPI:
> drivers/acpi/osl.c:208:10: warning: Using plain integer as NULL pointer
> drivers/acpi/tables/tbxface.c:411:49: warning: Using plain integer as NULL pointer
> drivers/acpi/processor_core.c:1008:10: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/acpi/osl.c | 2 +-
> drivers/acpi/processor_core.c | 2 +-
> drivers/acpi/tables/tbxface.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-2.6.20-git9.orig/drivers/acpi/osl.c
> +++ linux-2.6.20-git9/drivers/acpi/osl.c
> @@ -205,7 +205,7 @@ void __iomem *acpi_os_map_memory(acpi_ph
> {
> if (phys > ULONG_MAX) {
> printk(KERN_ERR PREFIX "Cannot map memory that high\n");
> - return 0;
> + return NULL;
> }
> if (acpi_gbl_permanent_mmap)
> /*
> --- linux-2.6.20-git9.orig/drivers/acpi/processor_core.c
> +++ linux-2.6.20-git9/drivers/acpi/processor_core.c
> @@ -1005,7 +1005,7 @@ static int __init acpi_processor_init(vo
> #ifdef CONFIG_SMP
> if (ACPI_FAILURE(acpi_get_table(ACPI_SIG_MADT, 0,
> (struct acpi_table_header **)&madt)))
> - madt = 0;
> + madt = NULL;
> #endif
>
> acpi_processor_dir = proc_mkdir(ACPI_PROCESSOR_CLASS, acpi_root_dir);
> --- linux-2.6.20-git9.orig/drivers/acpi/tables/tbxface.c
> +++ linux-2.6.20-git9/drivers/acpi/tables/tbxface.c
> @@ -408,7 +408,7 @@ acpi_get_table(char *signature,
> }
>
> if (!acpi_gbl_permanent_mmap) {
> - acpi_gbl_root_table_list.tables[i].pointer = 0;
> + acpi_gbl_root_table_list.tables[i].pointer = NULL;
> }
>
> return (status);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2007-02-14 23:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 0:11 [PATCH] ACPI: use NULL for ptrs Randy Dunlap
2007-02-14 23:17 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702141817.55746.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=akpm@osdl.org \
--cc=linux-acpi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.