From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] (pata-2.6 fix queue) sl82c105: DMA support code cleanup
Date: Wed, 14 Feb 2007 20:48:32 +0100 [thread overview]
Message-ID: <200702142048.32535.bzolnier@gmail.com> (raw)
In-Reply-To: <200702140043.25244.sshtylyov@ru.mvista.com>
On Tuesday 13 February 2007 22:43, Sergei Shtylyov wrote:
> Fold the now equivalent code in the ide_dma_check() method into a mere call to
> ide_use_dma(). Make config_for_dma() return non-zero if DMA mode has been set
> and call it from the ide_dma_check() method instead of ide_dma_on().
> Also, defer writing the DMA timings to the chip registers until DMA is actually
> turned on (and do not enable IORDY for DMA). Remove unnecessary code from the
> init_hwif() method, improve its looks overall, and also rename the driver's
> ide_dma_check() and dma_start() methods.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> The patch has been actually tested at last. :-)
> Note that now this driver can be joined to the ide-use-fast-pio patch.
applied
next prev parent reply other threads:[~2007-02-14 19:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 21:43 [PATCH] (pata-2.6 fix queue) sl82c105: DMA support code cleanup Sergei Shtylyov
2007-02-14 19:48 ` Bartlomiej Zolnierkiewicz [this message]
2007-02-23 16:10 ` [PATCH] (pata-2.6 fix queue) sl82c105: DMA support code cleanup (take 2) Sergei Shtylyov
2007-02-23 16:13 ` [PATCH] (pata-2.6 fix queue) sl82c105: DMA support code cleanup (take 3) Sergei Shtylyov
2007-02-23 23:42 ` Bartlomiej Zolnierkiewicz
2007-03-28 18:50 ` [PATCH pata-2.6] sl82c105: DMA support code cleanup (take 4) Sergei Shtylyov
2007-04-04 19:38 ` Bartlomiej Zolnierkiewicz
2007-03-28 20:24 ` [PATCH pata-2.6] sl82c105: add speedproc() method and MWDMA0/1 support Sergei Shtylyov
2007-04-04 19:38 ` Bartlomiej Zolnierkiewicz
2007-04-04 19:53 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702142048.32535.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.