From: "Cyrill V. Gorcunov" <gorcunov@gmail.com>
To: Helge Deller <deller@gmx.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel-list <linux-kernel@vger.kernel.org>
Subject: [PATCH] HIL: fix improper call of release_region v2
Date: Thu, 15 Feb 2007 22:25:13 +0300 [thread overview]
Message-ID: <20070215192513.GA12857@cvg> (raw)
Thist patch prevents from improper call of release_region
if the code has been compiled without CONFIG_HP300 support.
Signed-off-by: Cyrill V. Gorcunov <gorcunov@gmail.com>
---
An improved version (v2). Helge, please check it and Ack then.
drivers/input/keyboard/hilkbd.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/input/keyboard/hilkbd.c b/drivers/input/keyboard/hilkbd.c
index 255a6ec..4de4dc2 100644
--- a/drivers/input/keyboard/hilkbd.c
+++ b/drivers/input/keyboard/hilkbd.c
@@ -294,8 +294,10 @@ err3:
disable_irq(HIL_IRQ);
free_irq(HIL_IRQ, hil_dev.dev_id);
err2:
+#if defined(CONFIG_HP300)
release_region(HILBASE + HIL_DATA, 2);
err1:
+#endif
input_free_device(hil_dev.dev);
hil_dev.dev = NULL;
return err;
next reply other threads:[~2007-02-15 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 19:25 Cyrill V. Gorcunov [this message]
2007-02-15 19:31 ` [PATCH] HIL: fix improper call of release_region v2 Helge Deller
2007-02-15 20:22 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070215192513.GA12857@cvg \
--to=gorcunov@gmail.com \
--cc=akpm@osdl.org \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.