From: Ralf Baechle <ralf@linux-mips.org>
To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Cc: linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH] Fix __copy_{to,from}_user_inatomic
Date: Fri, 16 Feb 2007 15:54:42 +0000 [thread overview]
Message-ID: <20070216155441.GA26835@linux-mips.org> (raw)
In-Reply-To: <45D5CEA5.3050604@innova-card.com>
On Fri, Feb 16, 2007 at 04:32:53PM +0100, Franck Bui-Huu wrote:
> These functions are aliases to __copy_{to,from}_user resp but they
> are not allowed to sleep. Therefore might_sleep() must not be used
> by their implementions.
The _inatomic functions are know to buggy but this doesn't quite fix the
whole issues with them. On error __copy_from_user_inatomic should not
clear the non-copied part of the destination buffer. See
01408c4939479ec46c15aa7ef6e2406be50eeeca and
7c12d81134b130ccd4c286b434ca48c4cda71a2f for the rationale.
Ralf
next prev parent reply other threads:[~2007-02-16 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 15:32 [PATCH] Fix __copy_{to,from}_user_inatomic Franck Bui-Huu
2007-02-16 15:54 ` Ralf Baechle [this message]
2007-02-16 16:06 ` Franck Bui-Huu
2007-02-16 16:12 ` Atsushi Nemoto
2007-02-19 18:46 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070216155441.GA26835@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=vagabon.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.