All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] why so many more "down()" than "down_interruptible()"
Date: Sat, 17 Feb 2007 13:58:39 +0000	[thread overview]
Message-ID: <200702171458.40276.arnd@arndb.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0702170754290.23563@CPE00045a9c397f-CM001225dbafb6>

On Saturday 17 February 2007 14:00, Robert P. J. Day wrote:
>   that's not what i see.  just counting the calls under drivers/, it
> looks like there's about four times as many calls of down() as
> down_interruptible().  is there some reason that the actual stats
> differ so markedly from the claim in love's book?  just curious.

Using down_interruptible is hard: You need to be in a place where
you can return -EINTR (or -ERESTART*) to user space, and you need
to undo everything that your function did before the down_interruptible
failed.

	Arnd <><

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2007-02-17 13:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-17 13:00 [KJ] why so many more "down()" than "down_interruptible()" calls? Robert P. J. Day
2007-02-17 13:58 ` Arnd Bergmann [this message]
2007-02-17 14:03 ` [KJ] why so many more "down()" than "down_interruptible()" Robert P. J. Day
2007-02-17 15:56 ` Ahmed S. Darwish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702171458.40276.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.