diff for duplicates of <20070220000703.GN13958@stusta.de> diff --git a/a/1.txt b/N1/1.txt index 5df3ece..fa862b1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -686,8 +686,10 @@ This patch was already sent on: - char *name, const char *routine) -{ -#ifdef AURORA_PARANOIA_CHECK -- static const char *badmagic - KERN_DEBUG "aurora: Warning: bad aurora port magic number for device %s in %s\n"; -- static const char *badinfo - KERN_DEBUG "aurora: Warning: null aurora port for device %s in %s\n"; +- static const char *badmagic = +- KERN_DEBUG "aurora: Warning: bad aurora port magic number for device %s in %s\n"; +- static const char *badinfo = +- KERN_DEBUG "aurora: Warning: null aurora port for device %s in %s\n"; - - if (!port) { - printk(badinfo, name, routine); @@ -779,7 +781,7 @@ This patch was already sent on: - sbus_writeb(CCR_HARDRESET, &bp->r[chip]->r[CD180_CCR]); - udelay(1); - sti(); -- id\x1000; +- id=1000; - while((--id) && - (sbus_readb(&bp->r[chip]->r[CD180_GSVR])!=0xff))udelay(100); - if(!id) { @@ -835,7 +837,7 @@ This patch was already sent on: -{ -int i; -for(i=0;i<TYPE_1_IRQS;i++) -- if (type_1_irq[i]=irq) return 1; +- if (type_1_irq[i]==irq) return 1; -return 0; -} - @@ -859,8 +861,8 @@ This patch was already sent on: - printk(KERN_INFO "aurora: sio16 at %p\n",sdev); -#endif - if((sdev->reg_addrs[0].reg_size!=1) && -- (sdev->reg_addrs[1].reg_size!\x128) && -- (sdev->reg_addrs[2].reg_size!\x128) && +- (sdev->reg_addrs[1].reg_size!=128) && +- (sdev->reg_addrs[2].reg_size!=128) && - (sdev->reg_addrs[3].reg_size!=4)) { - printk(KERN_ERR "aurora%d: registers' sizes " - "do not match.\n", bn); @@ -871,7 +873,7 @@ This patch was already sent on: - sbus_ioremap(&sdev->resource[0], 0, - sdev->reg_addrs[0].reg_size, - "sio16"); -- if (bp->r0 = NULL) { +- if (bp->r0 == NULL) { - printk(KERN_ERR "aurora%d: can't map " - "reg_addrs[0]\n", bn); - break; @@ -883,7 +885,7 @@ This patch was already sent on: - sbus_ioremap(&sdev->resource[1], 0, - sdev->reg_addrs[1].reg_size, - "sio16"); -- if (bp->r[0] = NULL) { +- if (bp->r[0] == NULL) { - printk(KERN_ERR "aurora%d: can't map " - "reg_addrs[1]\n", bn); - break; @@ -895,7 +897,7 @@ This patch was already sent on: - sbus_ioremap(&sdev->resource[2], 0, - sdev->reg_addrs[2].reg_size, - "sio16"); -- if (bp->r[1] = NULL) { +- if (bp->r[1] == NULL) { - printk(KERN_ERR "aurora%d: can't map " - "reg_addrs[2]\n", bn); - break; @@ -907,7 +909,7 @@ This patch was already sent on: - sbus_ioremap(&sdev->resource[3], 0, - sdev->reg_addrs[3].reg_size, - "sio16"); -- if (bp->r3 = NULL) { +- if (bp->r3 == NULL) { - printk(KERN_ERR "aurora%d: can't map " - "reg_addrs[3]\n", bn); - break; @@ -942,7 +944,7 @@ This patch was already sent on: - bp->flags=0xff; - } - } -- if(bp->flags=0xff)break; +- if(bp->flags==0xff)break; - printk(KERN_INFO "aurora%d: irq %d\n",bn,bp->irq&0x0f); - buf[0]=0; - grrr=prom_getproperty(sdev->prom_node,"dtr_rts",buf,sizeof(buf)); @@ -950,23 +952,23 @@ This patch was already sent on: - printk(KERN_INFO "aurora%d: Swapped DTR and RTS\n",bn); - bp->DTR=MSVR_RTS; - bp->RTS=MSVR_DTR; -- bp->MSVDTRÍ180_MSVRTS; -- bp->MSVRTSÍ180_MSVDTR; +- bp->MSVDTR=CD180_MSVRTS; +- bp->MSVRTS=CD180_MSVDTR; - bp->flags|=AURORA_BOARD_DTR_FLOW_OK; - }else{ - #ifdef AURORA_FORCE_DTR_FLOW - printk(KERN_INFO "aurora%d: Forcing swapped DTR-RTS\n",bn); - bp->DTR=MSVR_RTS; - bp->RTS=MSVR_DTR; -- bp->MSVDTRÍ180_MSVRTS; -- bp->MSVRTSÍ180_MSVDTR; +- bp->MSVDTR=CD180_MSVRTS; +- bp->MSVRTS=CD180_MSVDTR; - bp->flags|=AURORA_BOARD_DTR_FLOW_OK; - #else - printk(KERN_INFO "aurora%d: Normal DTR and RTS\n",bn); - bp->DTR=MSVR_DTR; - bp->RTS=MSVR_RTS; -- bp->MSVDTRÍ180_MSVDTR; -- bp->MSVRTSÍ180_MSVRTS; +- bp->MSVDTR=CD180_MSVDTR; +- bp->MSVRTS=CD180_MSVRTS; - #endif - } - bp->oscfreq=prom_getint(sdev->prom_node,"clk")*100; @@ -1312,13 +1314,13 @@ This patch was already sent on: -#ifdef AURORA_INT_DEBUG - printk("R-ACK %02x\n", ack); -#endif -- if ((ack >> 5) = board_No(bp)) { +- if ((ack >> 5) == board_No(bp)) { - if ((chip=((ack>>3)&3)-1) < AURORA_NCD180) { -- if ((ack&GSVR_ITMASK)=GSVR_IT_RGD) { +- if ((ack&GSVR_ITMASK)==GSVR_IT_RGD) { - aurora_receive(bp,chip); - sbus_writeb(0, - &bp->r[chip]->r[CD180_EOSRR]); -- } else if ((ack & GSVR_ITMASK) = GSVR_IT_REXC) { +- } else if ((ack & GSVR_ITMASK) == GSVR_IT_REXC) { - aurora_receive_exc(bp,chip); - sbus_writeb(0, - &bp->r[chip]->r[CD180_EOSRR]); @@ -1330,9 +1332,9 @@ This patch was already sent on: -#ifdef AURORA_INT_DEBUG - printk("T-ACK %02x\n", ack); -#endif -- if ((ack >> 5) = board_No(bp)) { +- if ((ack >> 5) == board_No(bp)) { - if ((chip=((ack>>3)&3)-1) < AURORA_NCD180) { -- if ((ack&GSVR_ITMASK)=GSVR_IT_TX) { +- if ((ack&GSVR_ITMASK)==GSVR_IT_TX) { - aurora_transmit(bp,chip); - sbus_writeb(0, - &bp->r[chip]->r[CD180_EOSRR]); @@ -1344,9 +1346,9 @@ This patch was already sent on: -#ifdef AURORA_INT_DEBUG - printk("M-ACK %02x\n", ack); -#endif -- if ((ack >> 5) = board_No(bp)) { +- if ((ack >> 5) == board_No(bp)) { - if ((chip = ((ack>>3)&3)-1) < AURORA_NCD180) { -- if ((ack&GSVR_ITMASK)=GSVR_IT_MDM) { +- if ((ack&GSVR_ITMASK)==GSVR_IT_MDM) { - aurora_check_modem(bp,chip); - sbus_writeb(0, - &bp->r[chip]->r[CD180_EOSRR]); @@ -1365,22 +1367,22 @@ This patch was already sent on: -#ifdef AURORA_INT_DEBUG - printk("ACK: %02x\n",ack); -#endif -- if ((ack>>5)=board_No(bp)) { +- if ((ack>>5)==board_No(bp)) { - if ((chip=((ack>>3)&3)-1) < AURORA_NCD180) { - ack&=GSVR_ITMASK; -- if (ack=GSVR_IT_RGD) { +- if (ack==GSVR_IT_RGD) { - aurora_receive(bp,chip); - sbus_writeb(0, - &bp->r[chip]->r[CD180_EOSRR]); -- } else if (ack=GSVR_IT_REXC) { +- } else if (ack==GSVR_IT_REXC) { - aurora_receive_exc(bp,chip); - sbus_writeb(0, - &bp->r[chip]->r[CD180_EOSRR]); -- } else if (ack=GSVR_IT_TX) { +- } else if (ack==GSVR_IT_TX) { - aurora_transmit(bp,chip); - sbus_writeb(0, - &bp->r[chip]->r[CD180_EOSRR]); -- } else if (ack=GSVR_IT_MDM) { +- } else if (ack==GSVR_IT_MDM) { - aurora_check_modem(bp,chip); - sbus_writeb(0, - &bp->r[chip]->r[CD180_EOSRR]); @@ -1401,12 +1403,12 @@ This patch was already sent on: - - if (status & SRSR_REXT) { - ack = sbus_readb(&bp->r3->r[bp->ACK_RINT]); -- if (ack = (chip_id | GSVR_IT_RGD)) { +- if (ack == (chip_id | GSVR_IT_RGD)) { -#ifdef AURORA_INTMSG - printk("RX ACK\n"); -#endif - aurora_receive(bp,chip); -- } else if (ack = (chip_id | GSVR_IT_REXC)) { +- } else if (ack == (chip_id | GSVR_IT_REXC)) { -#ifdef AURORA_INTMSG - printk("RXC ACK\n"); -#endif @@ -1419,7 +1421,7 @@ This patch was already sent on: - } - } else if (status & SRSR_TEXT) { - ack = sbus_readb(&bp->r3->r[bp->ACK_TINT]); -- if (ack = (chip_id | GSVR_IT_TX)){ +- if (ack == (chip_id | GSVR_IT_TX)){ -#ifdef AURORA_INTMSG - printk("TX ACK\n"); -#endif @@ -1432,7 +1434,7 @@ This patch was already sent on: - } - } else if (status & SRSR_MEXT) { - ack = sbus_readb(&bp->r3->r[bp->ACK_MINT]); -- if (ack = (chip_id | GSVR_IT_MDM)){ +- if (ack == (chip_id | GSVR_IT_MDM)){ -#ifdef AURORA_INTMSG - printk("MDM ACK\n"); -#endif @@ -1522,7 +1524,7 @@ This patch was already sent on: - - if (aurora_init_CD180(bp,0))error=1;error=0; - if (aurora_init_CD180(bp,1))error++; -- if (error = AURORA_NCD180) { +- if (error == AURORA_NCD180) { - printk(KERN_ERR "Both chips failed initialisation.\n"); - return -EIO; - } @@ -1783,7 +1785,7 @@ This patch was already sent on: - clear_bit(TTY_IO_ERROR, &port->tty->flags); - -#ifdef MODULE -- if ((port->count = 1) && ((++bp->count) = 1)) +- if ((port->count == 1) && ((++bp->count) == 1)) - bp->flags |= AURORA_BOARD_ACTIVE; -#endif - @@ -2049,7 +2051,7 @@ This patch was already sent on: - } - - bp = port_Board(port); -- if ((tty->count = 1) && (port->count != 1)) { +- if ((tty->count == 1) && (port->count != 1)) { - printk(KERN_DEBUG "aurora%d: aurora_close: bad port count; " - "tty->count is 1, port count is %d\n", - board_No(bp), port->count); @@ -2431,12 +2433,14 @@ This patch was already sent on: - return -EINVAL; -#endif - -- change_speed = ((port->flags & ASYNC_SPD_MASK) !- (tmp.flags & ASYNC_SPD_MASK)); +- change_speed = ((port->flags & ASYNC_SPD_MASK) != +- (tmp.flags & ASYNC_SPD_MASK)); - - if (!capable(CAP_SYS_ADMIN)) { - if ((tmp.close_delay != port->close_delay) || - (tmp.closing_wait != port->closing_wait) || -- ((tmp.flags & ~ASYNC_USR_MASK) !- (port->flags & ~ASYNC_USR_MASK))) +- ((tmp.flags & ~ASYNC_USR_MASK) != +- (port->flags & ~ASYNC_USR_MASK))) - return -EPERM; - port->flags = ((port->flags & ~ASYNC_USR_MASK) | - (tmp.flags & ASYNC_USR_MASK)); @@ -2520,7 +2524,8 @@ This patch was already sent on: - case TIOCSSOFTCAR: - if (get_user(arg,(unsigned long *)arg)) - return -EFAULT; -- tty->termios->c_cflag - ((tty->termios->c_cflag & ~CLOCAL) | +- tty->termios->c_cflag = +- ((tty->termios->c_cflag & ~CLOCAL) | - (arg ? CLOCAL : 0)); - return 0; - case TIOCGSERIAL: @@ -2726,8 +2731,8 @@ This patch was already sent on: - if ((aurora_paranoia_check(port, tty->name, "aurora_set_termios")) - return; - -- if (tty->termios->c_cflag = old_termios->c_cflag && -- tty->termios->c_iflag = old_termios->c_iflag) +- if (tty->termios->c_cflag == old_termios->c_cflag && +- tty->termios->c_iflag == old_termios->c_iflag) - return; - - save_flags(flags); cli(); @@ -2758,7 +2763,7 @@ This patch was already sent on: - printk("do_softint: start\n"); -#endif - tty = port->tty; -- if (tty = NULL) +- if (tty == NULL) - return; - - if (test_and_clear_bit(RS_EVENT_WRITE_WAKEUP, &port->event)) { @@ -2798,7 +2803,7 @@ This patch was already sent on: - printk("aurora_init_drivers: start\n"); -#endif - tmp_buf = (unsigned char *) get_zeroed_page(GFP_KERNEL); -- if (tmp_buf = NULL) { +- if (tmp_buf == NULL) { - printk(KERN_ERR "aurora: Couldn't get free page.\n"); - return 1; - } @@ -2815,7 +2820,8 @@ This patch was already sent on: - aurora_driver->type = TTY_DRIVER_TYPE_SERIAL; - aurora_driver->subtype = SERIAL_TYPE_NORMAL; - aurora_driver->init_termios = tty_std_termios; -- aurora_driver->init_termios.c_cflag - B9600 | CS8 | CREAD | HUPCL | CLOCAL; +- aurora_driver->init_termios.c_cflag = +- B9600 | CS8 | CREAD | HUPCL | CLOCAL; - aurora_driver->flags = TTY_DRIVER_REAL_RAW; - tty_set_operations(aurora_driver, &aurora_ops); - error = tty_register_driver(aurora_driver); diff --git a/a/content_digest b/N1/content_digest index 36e99e0..fdb20ac 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,6 @@ - "ref\020070104185338.GH20714@stusta.de\0" "From\0Adrian Bunk <bunk@stusta.de>\0" "Subject\0[RFC: 2.6 patch] remove the broken SUN_AURORA driver\0" - "Date\0Tue, 20 Feb 2007 00:07:03 +0000\0" + "Date\0Tue, 20 Feb 2007 01:07:03 +0100\0" "To\0Andrew Morton <akpm@osdl.org>\0" "Cc\0sparclinux@vger.kernel.org" " linux-kernel@vger.kernel.org\0" @@ -695,8 +694,10 @@ "-\t\t\t\t char *name, const char *routine)\n" "-{\n" "-#ifdef AURORA_PARANOIA_CHECK\n" - "-\tstatic const char *badmagic -\t\tKERN_DEBUG \"aurora: Warning: bad aurora port magic number for device %s in %s\\n\";\n" - "-\tstatic const char *badinfo -\t\tKERN_DEBUG \"aurora: Warning: null aurora port for device %s in %s\\n\";\n" + "-\tstatic const char *badmagic =\n" + "-\t\tKERN_DEBUG \"aurora: Warning: bad aurora port magic number for device %s in %s\\n\";\n" + "-\tstatic const char *badinfo =\n" + "-\t\tKERN_DEBUG \"aurora: Warning: null aurora port for device %s in %s\\n\";\n" "-\n" "-\tif (!port) {\n" "-\t\tprintk(badinfo, name, routine);\n" @@ -788,7 +789,7 @@ "-\tsbus_writeb(CCR_HARDRESET, &bp->r[chip]->r[CD180_CCR]);\n" "-\tudelay(1);\n" "-\tsti();\n" - "-\tid\02000;\n" + "-\tid=1000;\n" "-\twhile((--id) &&\n" "-\t (sbus_readb(&bp->r[chip]->r[CD180_GSVR])!=0xff))udelay(100);\n" "-\tif(!id) {\n" @@ -844,7 +845,7 @@ "-{\n" "-int i;\n" "-for(i=0;i<TYPE_1_IRQS;i++)\n" - "-\tif (type_1_irq[i]=irq) return 1;\n" + "-\tif (type_1_irq[i]==irq) return 1;\n" "-return 0;\n" "-}\n" "-\n" @@ -868,8 +869,8 @@ "-\t\t\t\tprintk(KERN_INFO \"aurora: sio16 at %p\\n\",sdev);\n" "-#endif\n" "-\t\t\t\tif((sdev->reg_addrs[0].reg_size!=1) &&\n" - "-\t\t\t\t (sdev->reg_addrs[1].reg_size!\0228) &&\n" - "-\t\t\t\t (sdev->reg_addrs[2].reg_size!\0228) &&\n" + "-\t\t\t\t (sdev->reg_addrs[1].reg_size!=128) &&\n" + "-\t\t\t\t (sdev->reg_addrs[2].reg_size!=128) &&\n" "-\t\t\t\t (sdev->reg_addrs[3].reg_size!=4)) {\n" "-\t\t\t\t \tprintk(KERN_ERR \"aurora%d: registers' sizes \"\n" "-\t\t\t\t\t \"do not match.\\n\", bn);\n" @@ -880,7 +881,7 @@ "-\t\t\t\t\tsbus_ioremap(&sdev->resource[0], 0,\n" "-\t\t\t\t\t\t sdev->reg_addrs[0].reg_size,\n" "-\t\t\t\t\t\t \"sio16\");\n" - "-\t\t\t\tif (bp->r0 = NULL) {\n" + "-\t\t\t\tif (bp->r0 == NULL) {\n" "-\t\t\t\t\tprintk(KERN_ERR \"aurora%d: can't map \"\n" "-\t\t\t\t\t \"reg_addrs[0]\\n\", bn);\n" "-\t\t\t\t\tbreak;\n" @@ -892,7 +893,7 @@ "-\t\t\t\t\tsbus_ioremap(&sdev->resource[1], 0,\n" "-\t\t\t\t\t\t sdev->reg_addrs[1].reg_size,\n" "-\t\t\t\t\t\t \"sio16\");\n" - "-\t\t\t\tif (bp->r[0] = NULL) {\n" + "-\t\t\t\tif (bp->r[0] == NULL) {\n" "-\t\t\t\t\tprintk(KERN_ERR \"aurora%d: can't map \"\n" "-\t\t\t\t\t \"reg_addrs[1]\\n\", bn);\n" "-\t\t\t\t\tbreak;\n" @@ -904,7 +905,7 @@ "-\t\t\t\t\tsbus_ioremap(&sdev->resource[2], 0,\n" "-\t\t\t\t\t\t sdev->reg_addrs[2].reg_size,\n" "-\t\t\t\t\t\t \"sio16\");\n" - "-\t\t\t\tif (bp->r[1] = NULL) {\n" + "-\t\t\t\tif (bp->r[1] == NULL) {\n" "-\t\t\t\t\tprintk(KERN_ERR \"aurora%d: can't map \"\n" "-\t\t\t\t\t \"reg_addrs[2]\\n\", bn);\n" "-\t\t\t\t\tbreak;\n" @@ -916,7 +917,7 @@ "-\t\t\t\t\tsbus_ioremap(&sdev->resource[3], 0,\n" "-\t\t\t\t\t\t sdev->reg_addrs[3].reg_size,\n" "-\t\t\t\t\t\t \"sio16\");\n" - "-\t\t\t\tif (bp->r3 = NULL) {\n" + "-\t\t\t\tif (bp->r3 == NULL) {\n" "-\t\t\t\t\tprintk(KERN_ERR \"aurora%d: can't map \"\n" "-\t\t\t\t\t \"reg_addrs[3]\\n\", bn);\n" "-\t\t\t\t\tbreak;\n" @@ -951,7 +952,7 @@ "-\t\t\t\t\tbp->flags=0xff;\n" "-\t\t\t\t\t}\n" "-\t\t\t\t}\n" - "-\t\t\t\tif(bp->flags=0xff)break;\n" + "-\t\t\t\tif(bp->flags==0xff)break;\n" "-\t\t\t\tprintk(KERN_INFO \"aurora%d: irq %d\\n\",bn,bp->irq&0x0f);\n" "-\t\t\t\tbuf[0]=0;\n" "-\t\t\t\tgrrr=prom_getproperty(sdev->prom_node,\"dtr_rts\",buf,sizeof(buf));\n" @@ -959,23 +960,23 @@ "-\t\t\t\t\tprintk(KERN_INFO \"aurora%d: Swapped DTR and RTS\\n\",bn);\n" "-\t\t\t\t\tbp->DTR=MSVR_RTS;\n" "-\t\t\t\t\tbp->RTS=MSVR_DTR;\n" - "-\t\t\t\t\tbp->MSVDTR\303\215180_MSVRTS;\n" - "-\t\t\t\t\tbp->MSVRTS\303\215180_MSVDTR;\n" + "-\t\t\t\t\tbp->MSVDTR=CD180_MSVRTS;\n" + "-\t\t\t\t\tbp->MSVRTS=CD180_MSVDTR;\n" "-\t\t\t\t\tbp->flags|=AURORA_BOARD_DTR_FLOW_OK;\n" "-\t\t\t\t\t}else{\n" "-\t\t\t\t\t#ifdef AURORA_FORCE_DTR_FLOW\n" "-\t\t\t\t\tprintk(KERN_INFO \"aurora%d: Forcing swapped DTR-RTS\\n\",bn);\n" "-\t\t\t\t\tbp->DTR=MSVR_RTS;\n" "-\t\t\t\t\tbp->RTS=MSVR_DTR;\n" - "-\t\t\t\t\tbp->MSVDTR\303\215180_MSVRTS;\n" - "-\t\t\t\t\tbp->MSVRTS\303\215180_MSVDTR;\n" + "-\t\t\t\t\tbp->MSVDTR=CD180_MSVRTS;\n" + "-\t\t\t\t\tbp->MSVRTS=CD180_MSVDTR;\n" "-\t\t\t\t\tbp->flags|=AURORA_BOARD_DTR_FLOW_OK;\n" "-\t\t\t\t\t#else\n" "-\t\t\t\t\tprintk(KERN_INFO \"aurora%d: Normal DTR and RTS\\n\",bn);\n" "-\t\t\t\t\tbp->DTR=MSVR_DTR;\n" "-\t\t\t\t\tbp->RTS=MSVR_RTS;\n" - "-\t\t\t\t\tbp->MSVDTR\303\215180_MSVDTR;\n" - "-\t\t\t\t\tbp->MSVRTS\303\215180_MSVRTS;\n" + "-\t\t\t\t\tbp->MSVDTR=CD180_MSVDTR;\n" + "-\t\t\t\t\tbp->MSVRTS=CD180_MSVRTS;\n" "-\t\t\t\t\t#endif\n" "-\t\t\t\t}\n" "-\t\t\t\tbp->oscfreq=prom_getint(sdev->prom_node,\"clk\")*100;\n" @@ -1321,13 +1322,13 @@ "-#ifdef AURORA_INT_DEBUG\n" "-\t\t\tprintk(\"R-ACK %02x\\n\", ack);\n" "-#endif\n" - "-\t\t\tif ((ack >> 5) = board_No(bp)) {\n" + "-\t\t\tif ((ack >> 5) == board_No(bp)) {\n" "-\t\t\t\tif ((chip=((ack>>3)&3)-1) < AURORA_NCD180) {\n" - "-\t\t\t\t\tif ((ack&GSVR_ITMASK)=GSVR_IT_RGD) {\n" + "-\t\t\t\t\tif ((ack&GSVR_ITMASK)==GSVR_IT_RGD) {\n" "-\t\t\t\t\t\taurora_receive(bp,chip);\n" "-\t\t\t\t\t\tsbus_writeb(0,\n" "-\t\t\t\t\t\t\t &bp->r[chip]->r[CD180_EOSRR]);\n" - "-\t\t\t\t\t} else if ((ack & GSVR_ITMASK) = GSVR_IT_REXC) {\n" + "-\t\t\t\t\t} else if ((ack & GSVR_ITMASK) == GSVR_IT_REXC) {\n" "-\t\t\t\t\t\taurora_receive_exc(bp,chip);\n" "-\t\t\t\t\t\tsbus_writeb(0,\n" "-\t\t\t\t\t\t\t &bp->r[chip]->r[CD180_EOSRR]);\n" @@ -1339,9 +1340,9 @@ "-#ifdef AURORA_INT_DEBUG\n" "-\t\t\tprintk(\"T-ACK %02x\\n\", ack);\n" "-#endif\n" - "-\t\t\tif ((ack >> 5) = board_No(bp)) {\n" + "-\t\t\tif ((ack >> 5) == board_No(bp)) {\n" "-\t\t\t\tif ((chip=((ack>>3)&3)-1) < AURORA_NCD180) {\n" - "-\t\t\t\t\tif ((ack&GSVR_ITMASK)=GSVR_IT_TX) {\n" + "-\t\t\t\t\tif ((ack&GSVR_ITMASK)==GSVR_IT_TX) {\n" "-\t\t\t\t\t\taurora_transmit(bp,chip);\n" "-\t\t\t\t\t\tsbus_writeb(0,\n" "-\t\t\t\t\t\t\t &bp->r[chip]->r[CD180_EOSRR]);\n" @@ -1353,9 +1354,9 @@ "-#ifdef AURORA_INT_DEBUG\n" "-\t\t\tprintk(\"M-ACK %02x\\n\", ack);\n" "-#endif\n" - "-\t\t\tif ((ack >> 5) = board_No(bp)) {\n" + "-\t\t\tif ((ack >> 5) == board_No(bp)) {\n" "-\t\t\t\tif ((chip = ((ack>>3)&3)-1) < AURORA_NCD180) {\n" - "-\t\t\t\t\tif ((ack&GSVR_ITMASK)=GSVR_IT_MDM) {\n" + "-\t\t\t\t\tif ((ack&GSVR_ITMASK)==GSVR_IT_MDM) {\n" "-\t\t\t\t\t\taurora_check_modem(bp,chip);\n" "-\t\t\t\t\t\tsbus_writeb(0,\n" "-\t\t\t\t\t\t\t &bp->r[chip]->r[CD180_EOSRR]);\n" @@ -1374,22 +1375,22 @@ "-#ifdef AURORA_INT_DEBUG\n" "-\t\tprintk(\"ACK: %02x\\n\",ack);\n" "-#endif\n" - "-\t\tif ((ack>>5)=board_No(bp)) {\n" + "-\t\tif ((ack>>5)==board_No(bp)) {\n" "-\t\t\tif ((chip=((ack>>3)&3)-1) < AURORA_NCD180) {\n" "-\t\t\t\tack&=GSVR_ITMASK;\n" - "-\t\t\t\tif (ack=GSVR_IT_RGD) {\n" + "-\t\t\t\tif (ack==GSVR_IT_RGD) {\n" "-\t\t\t\t\taurora_receive(bp,chip);\n" "-\t\t\t\t\tsbus_writeb(0,\n" "-\t\t\t\t\t\t &bp->r[chip]->r[CD180_EOSRR]);\n" - "-\t\t\t\t} else if (ack=GSVR_IT_REXC) {\n" + "-\t\t\t\t} else if (ack==GSVR_IT_REXC) {\n" "-\t\t\t\t\taurora_receive_exc(bp,chip);\n" "-\t\t\t\t\tsbus_writeb(0,\n" "-\t\t\t\t\t\t &bp->r[chip]->r[CD180_EOSRR]);\n" - "-\t\t\t\t} else if (ack=GSVR_IT_TX) {\n" + "-\t\t\t\t} else if (ack==GSVR_IT_TX) {\n" "-\t\t\t\t\taurora_transmit(bp,chip);\n" "-\t\t\t\t\tsbus_writeb(0,\n" "-\t\t\t\t\t\t &bp->r[chip]->r[CD180_EOSRR]);\n" - "-\t\t\t\t} else if (ack=GSVR_IT_MDM) {\n" + "-\t\t\t\t} else if (ack==GSVR_IT_MDM) {\n" "-\t\t\t\t\taurora_check_modem(bp,chip);\n" "-\t\t\t\t\tsbus_writeb(0,\n" "-\t\t\t\t\t\t &bp->r[chip]->r[CD180_EOSRR]);\n" @@ -1410,12 +1411,12 @@ "-\n" "-\t\t\tif (status & SRSR_REXT) {\n" "-\t\t\t\tack = sbus_readb(&bp->r3->r[bp->ACK_RINT]);\n" - "-\t\t\t\tif (ack = (chip_id | GSVR_IT_RGD)) {\n" + "-\t\t\t\tif (ack == (chip_id | GSVR_IT_RGD)) {\n" "-#ifdef AURORA_INTMSG\n" "-\t\t\t\t\tprintk(\"RX ACK\\n\");\n" "-#endif\n" "-\t\t\t\t\taurora_receive(bp,chip);\n" - "-\t\t\t\t} else if (ack = (chip_id | GSVR_IT_REXC)) {\n" + "-\t\t\t\t} else if (ack == (chip_id | GSVR_IT_REXC)) {\n" "-#ifdef AURORA_INTMSG\n" "-\t\t\t\t\tprintk(\"RXC ACK\\n\");\n" "-#endif\n" @@ -1428,7 +1429,7 @@ "-\t\t\t\t}\n" "-\t\t\t} else if (status & SRSR_TEXT) {\n" "-\t\t\t\tack = sbus_readb(&bp->r3->r[bp->ACK_TINT]);\n" - "-\t\t\t\tif (ack = (chip_id | GSVR_IT_TX)){\n" + "-\t\t\t\tif (ack == (chip_id | GSVR_IT_TX)){\n" "-#ifdef AURORA_INTMSG\n" "-\t\t\t\t\tprintk(\"TX ACK\\n\");\n" "-#endif\n" @@ -1441,7 +1442,7 @@ "-\t\t\t\t}\n" "-\t\t\t} else if (status & SRSR_MEXT) {\n" "-\t\t\t\tack = sbus_readb(&bp->r3->r[bp->ACK_MINT]);\n" - "-\t\t\t\tif (ack = (chip_id | GSVR_IT_MDM)){\n" + "-\t\t\t\tif (ack == (chip_id | GSVR_IT_MDM)){\n" "-#ifdef AURORA_INTMSG\n" "-\t\t\t\t\tprintk(\"MDM ACK\\n\");\n" "-#endif\n" @@ -1531,7 +1532,7 @@ "-\n" "-\tif (aurora_init_CD180(bp,0))error=1;error=0;\n" "-\tif (aurora_init_CD180(bp,1))error++;\n" - "-\tif (error = AURORA_NCD180) {\n" + "-\tif (error == AURORA_NCD180) {\n" "-\t\tprintk(KERN_ERR \"Both chips failed initialisation.\\n\");\n" "-\t\treturn -EIO;\n" "-\t}\n" @@ -1792,7 +1793,7 @@ "-\t\tclear_bit(TTY_IO_ERROR, &port->tty->flags);\n" "-\t\t\n" "-#ifdef MODULE\n" - "-\tif ((port->count = 1) && ((++bp->count) = 1))\n" + "-\tif ((port->count == 1) && ((++bp->count) == 1))\n" "-\t\t\tbp->flags |= AURORA_BOARD_ACTIVE;\n" "-#endif\n" "-\n" @@ -2058,7 +2059,7 @@ "-\t}\n" "-\t\n" "-\tbp = port_Board(port);\n" - "-\tif ((tty->count = 1) && (port->count != 1)) {\n" + "-\tif ((tty->count == 1) && (port->count != 1)) {\n" "-\t\tprintk(KERN_DEBUG \"aurora%d: aurora_close: bad port count; \"\n" "-\t\t \"tty->count is 1, port count is %d\\n\",\n" "-\t\t board_No(bp), port->count);\n" @@ -2440,12 +2441,14 @@ "-\t\treturn -EINVAL;\n" "-#endif\t\n" "-\t\n" - "-\tchange_speed = ((port->flags & ASYNC_SPD_MASK) !-\t\t\t(tmp.flags & ASYNC_SPD_MASK));\n" + "-\tchange_speed = ((port->flags & ASYNC_SPD_MASK) !=\n" + "-\t\t\t(tmp.flags & ASYNC_SPD_MASK));\n" "-\t\n" "-\tif (!capable(CAP_SYS_ADMIN)) {\n" "-\t\tif ((tmp.close_delay != port->close_delay) ||\n" "-\t\t (tmp.closing_wait != port->closing_wait) ||\n" - "-\t\t ((tmp.flags & ~ASYNC_USR_MASK) !-\t\t (port->flags & ~ASYNC_USR_MASK))) \n" + "-\t\t ((tmp.flags & ~ASYNC_USR_MASK) !=\n" + "-\t\t (port->flags & ~ASYNC_USR_MASK))) \n" "-\t\t\treturn -EPERM;\n" "-\t\tport->flags = ((port->flags & ~ASYNC_USR_MASK) |\n" "-\t\t\t (tmp.flags & ASYNC_USR_MASK));\n" @@ -2529,7 +2532,8 @@ "-\tcase TIOCSSOFTCAR:\n" "-\t\tif (get_user(arg,(unsigned long *)arg))\n" "-\t\t\treturn -EFAULT;\n" - "-\t\ttty->termios->c_cflag -\t\t\t((tty->termios->c_cflag & ~CLOCAL) |\n" + "-\t\ttty->termios->c_cflag =\n" + "-\t\t\t((tty->termios->c_cflag & ~CLOCAL) |\n" "-\t\t\t (arg ? CLOCAL : 0));\n" "-\t\treturn 0;\n" "-\tcase TIOCGSERIAL:\t\n" @@ -2735,8 +2739,8 @@ "-\tif ((aurora_paranoia_check(port, tty->name, \"aurora_set_termios\"))\n" "-\t\treturn;\n" "-\t\n" - "-\tif (tty->termios->c_cflag = old_termios->c_cflag &&\n" - "-\t tty->termios->c_iflag = old_termios->c_iflag)\n" + "-\tif (tty->termios->c_cflag == old_termios->c_cflag &&\n" + "-\t tty->termios->c_iflag == old_termios->c_iflag)\n" "-\t\treturn;\n" "-\n" "-\tsave_flags(flags); cli();\n" @@ -2767,7 +2771,7 @@ "-\tprintk(\"do_softint: start\\n\");\n" "-#endif\n" "-\ttty = port->tty;\n" - "-\tif (tty = NULL)\n" + "-\tif (tty == NULL)\n" "-\t\treturn;\n" "-\n" "-\tif (test_and_clear_bit(RS_EVENT_WRITE_WAKEUP, &port->event)) {\n" @@ -2807,7 +2811,7 @@ "-\tprintk(\"aurora_init_drivers: start\\n\");\n" "-#endif\n" "-\ttmp_buf = (unsigned char *) get_zeroed_page(GFP_KERNEL);\n" - "-\tif (tmp_buf = NULL) {\n" + "-\tif (tmp_buf == NULL) {\n" "-\t\tprintk(KERN_ERR \"aurora: Couldn't get free page.\\n\");\n" "-\t\treturn 1;\n" "-\t}\n" @@ -2824,7 +2828,8 @@ "-\taurora_driver->type = TTY_DRIVER_TYPE_SERIAL;\n" "-\taurora_driver->subtype = SERIAL_TYPE_NORMAL;\n" "-\taurora_driver->init_termios = tty_std_termios;\n" - "-\taurora_driver->init_termios.c_cflag -\t\tB9600 | CS8 | CREAD | HUPCL | CLOCAL;\n" + "-\taurora_driver->init_termios.c_cflag =\n" + "-\t\tB9600 | CS8 | CREAD | HUPCL | CLOCAL;\n" "-\taurora_driver->flags = TTY_DRIVER_REAL_RAW;\n" "-\ttty_set_operations(aurora_driver, &aurora_ops);\n" "-\terror = tty_register_driver(aurora_driver);\n" @@ -2953,4 +2958,4 @@ "-module_exit(aurora_cleanup);\n" "-MODULE_LICENSE(\"GPL\");" -5e575a62407e6aca7566613f02ef1bfed70bd2c24b1b6ce1d18d7c5dd81c93e8 +8d8e78881f6e40dc7ae7f42b2a098dc4a089156bbc39eb5a5331bf705c099957
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.