From: David Chinner <dgc@sgi.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: xfs-masters@oss.sgi.com, linux-kernel@vger.kernel.org, tes@sgi.com
Subject: Re: [2.6 patch] make xfs_buftarg_list static again
Date: Tue, 20 Feb 2007 11:41:38 +1100 [thread overview]
Message-ID: <20070220004138.GW5724@melbourne.sgi.com> (raw)
In-Reply-To: <20070220000747.GC13958@stusta.de>
On Tue, Feb 20, 2007 at 01:07:47AM +0100, Adrian Bunk wrote:
> xfs_buftarg_list became global for no good reason.
Fallout from a much larger patch. Looks like there were a couple
of STATIC -> static conversions stuffed up. Thanks for catching
this, Adrian.
Tim - another one for you ;)
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
> --- linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c.old 2007-02-18 22:55:40.000000000 +0100
> +++ linux-2.6.20-mm2/fs/xfs/linux-2.6/xfs_buf.c 2007-02-18 22:56:08.000000000 +0100
> @@ -1424,7 +1424,7 @@
> /*
> * buftarg list for delwrite queue processing
> */
> -LIST_HEAD(xfs_buftarg_list);
> +static LIST_HEAD(xfs_buftarg_list);
> static DEFINE_SPINLOCK(xfs_buftarg_lock);
>
> STATIC void
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-02-20 1:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 0:07 [2.6 patch] make xfs_buftarg_list static again Adrian Bunk
2007-02-20 0:41 ` David Chinner [this message]
2007-02-20 1:08 ` [xfs-masters] " Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070220004138.GW5724@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tes@sgi.com \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.