From: Michael Buesch <mb@bu3sch.de>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH] d80211: Fix max_signal values signedness bug
Date: Tue, 20 Feb 2007 20:45:01 +0100 [thread overview]
Message-ID: <200702202045.02075.mb@bu3sch.de> (raw)
char is not signed on all architectures.
This fixes a compiletime warning and bug on PPC.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: bu3sch-wireless-dev/include/net/d80211.h
===================================================================
--- bu3sch-wireless-dev.orig/include/net/d80211.h 2007-02-20 20:35:17.000000000 +0100
+++ bu3sch-wireless-dev/include/net/d80211.h 2007-02-20 20:42:13.000000000 +0100
@@ -542,9 +542,9 @@ struct ieee80211_hw {
int channel_change_time;
/* Maximum values for various statistics.
* Leave at 0 to indicate no support. Use negative numbers for dBm. */
- char max_rssi;
- char max_signal;
- char max_noise;
+ s8 max_rssi;
+ s8 max_signal;
+ s8 max_noise;
/* Number of available hardware TX queues for data packets.
* WMM requires at least four queues. */
--
Greetings Michael.
reply other threads:[~2007-02-20 19:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702202045.02075.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.