From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Randy Dunlap <rdunlap@xenotime.net>,
Dave Jones <davej@redhat.com>,
Chuck Wolber <chuckw@quantumlinux.com>,
Chris Wedgwood <reviews@ml.cw.f00f.org>,
Michael Krufky <mkrufky@linuxtv.org>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk, Ang Way Chuang <wcang@nrg.cs.usm.my>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [patch 10/18] dvb-core: fix bug in CRC-32 checking on 64-bit systems
Date: Tue, 20 Feb 2007 17:50:41 -0800 [thread overview]
Message-ID: <20070221015041.GK3684@kroah.com> (raw)
In-Reply-To: <20070221014927.GA3684@kroah.com>
[-- Attachment #1: dvb-core-fix-bug-in-CRC-32-checking-on-64-bit-systems.patch --]
[-- Type: text/plain, Size: 1894 bytes --]
-stable review patch. If anyone has any objections, please let us know.
------------------
From: Ang Way Chuang <wcang@nrg.cs.usm.my>
CRC-32 checking during ULE decapsulation always failed on x86_64 systems due
to the size of a variable used to store CRC. This bug was discovered on
Fedora Core 6 with kernel-2.6.18-1.2849. The i386 counterpart has no such
problem. This patch has been tested on 64-bit system as well as 32-bit system.
(cherry picked from commit dedcefb085fe98a1feaf63590fe2fc7e0ecb1987)
Signed-off-by: Ang Way Chuang <wcang@nrg.cs.usm.my>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/media/dvb/dvb-core/dvb_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.18.7.orig/drivers/media/dvb/dvb-core/dvb_net.c
+++ linux-2.6.18.7/drivers/media/dvb/dvb-core/dvb_net.c
@@ -604,7 +604,7 @@ static void dvb_net_ule( struct net_devi
{ &utype, sizeof utype },
{ priv->ule_skb->data, priv->ule_skb->len - 4 }
};
- unsigned long ule_crc = ~0L, expected_crc;
+ u32 ule_crc = ~0L, expected_crc;
if (priv->ule_dbit) {
/* Set D-bit for CRC32 verification,
* if it was set originally. */
@@ -617,7 +617,7 @@ static void dvb_net_ule( struct net_devi
*((u8 *)priv->ule_skb->tail - 2) << 8 |
*((u8 *)priv->ule_skb->tail - 1);
if (ule_crc != expected_crc) {
- printk(KERN_WARNING "%lu: CRC32 check FAILED: %#lx / %#lx, SNDU len %d type %#x, ts_remain %d, next 2: %x.\n",
+ printk(KERN_WARNING "%lu: CRC32 check FAILED: %08x / %08x, SNDU len %d type %#x, ts_remain %d, next 2: %x.\n",
priv->ts_count, ule_crc, expected_crc, priv->ule_sndu_len, priv->ule_sndu_type, ts_remain, ts_remain > 2 ? *(unsigned short *)from_where : 0);
#ifdef ULE_DEBUG
--
next prev parent reply other threads:[~2007-02-21 1:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070221014413.282048309@mini.kroah.org>
2007-02-21 1:49 ` [patch 00/18] 2.6.18-stable review Greg KH
2007-02-21 1:49 ` [patch 01/18] bcm43xx: Fix for oops on resume Greg KH
2007-02-23 5:25 ` Pavel Machek
2007-02-25 2:30 ` Larry Finger
2007-02-25 8:53 ` Andrew Morton
2007-02-21 1:49 ` [patch 02/18] bcm43xx: Fix for oops on ampdu status Greg KH
2007-02-21 1:49 ` [patch 03/18] Dont leak NT bit into next task Greg KH
2007-02-21 10:00 ` Giuseppe Bilotta
2007-02-21 17:14 ` Jan Engelhardt
2007-02-21 17:20 ` Chuck Ebbert
2007-02-22 15:29 ` Adrian Bunk
2007-02-22 16:56 ` Andi Kleen
2007-02-21 1:50 ` [patch 04/18] SCSI: add missing cdb clearing in scsi_execute() Greg KH
2007-02-21 1:50 ` [patch 05/18] IB/srp: Fix FMR mapping for 32-bit kernels and addresses above 4G Greg KH
2007-02-21 1:50 ` [patch 06/18] i2c: fix broken ds1337 initialization Greg KH
2007-02-21 1:50 ` [patch 07/18] grow_buffers() infinite loop fix (CVE-2006-5757, CVE-2006-6060) Greg KH
2007-02-21 1:50 ` [patch 08/18] hfs_fill_super returns success even if no root inode (CVE-2006-6056) Greg KH
2007-02-21 1:50 ` [patch 09/18] IB/mad: Fix race between cancel and receive completion Greg KH
2007-02-21 1:50 ` Greg KH [this message]
2007-02-21 1:50 ` [patch 11/18] v4l: cx2341x audio_properties is an u16, not u8 Greg KH
2007-02-21 1:50 ` [patch 12/18] v4l: cx88: Fix leadtek_eeprom tagging Greg KH
2007-02-21 1:51 ` [patch 13/18] V4L: cx88: Fix lockup on suspend Greg KH
2007-02-22 1:14 ` Michael Krufky
2007-02-23 23:50 ` Greg KH
2007-02-21 1:51 ` [patch 14/18] V4L: Fix quickcam communicator driver for big endian architectures Greg KH
2007-02-21 1:51 ` [patch 15/18] V4L: fix ks0127 status flags Greg KH
2007-02-21 1:51 ` [patch 16/18] V4L: tveeprom: autodetect LG TAPC G701D as tuner type 37 Greg KH
2007-02-21 1:51 ` [patch 17/18] V4L: buf_qbuf: fix videobuf_queue->stream corruption and lockup Greg KH
2007-02-21 1:51 ` [uml-devel] [patch 18/18] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted Greg KH
2007-02-21 1:51 ` Greg KH
2007-02-21 11:55 ` [patch 00/18] 2.6.18-stable review S.Çağlar Onur
2007-02-21 17:34 ` [stable] " Greg KH
2007-02-21 18:30 ` S.Çağlar Onur
2007-02-21 18:45 ` Ismail Dönmez
2007-02-22 5:42 ` Willy Tarreau
2007-02-26 0:00 ` Adrian Bunk
2007-02-26 0:18 ` Adrian Bunk
2007-03-05 13:44 ` S.Çağlar Onur
2007-03-05 19:26 ` Greg KH
2007-03-05 20:13 ` S.Çağlar Onur
2007-02-23 20:21 ` Hugh Dickins
2007-02-23 20:34 ` [stable] " Chris Wright
2007-02-23 21:13 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221015041.GK3684@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mkrufky@linuxtv.org \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wcang@nrg.cs.usm.my \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.