From: "Shawn O. Pearce" <spearce@spearce.org>
To: Pavel Roskin <proski@gnu.org>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] git-remote: support remotes with a dot in the name
Date: Wed, 21 Feb 2007 02:29:21 -0500 [thread overview]
Message-ID: <20070221072921.GB28152@spearce.org> (raw)
In-Reply-To: <20070221021206.8onspw0840gcs8ck@webmail.spamcop.net>
Pavel Roskin <proski@gnu.org> wrote:
> I was thinking of something like
>
> [remote "wireless-2.6"]
> url = http://foo/bar
> url.push = ssh://foo/bar
The key `url.push` is not a valid string in a config file.
> > But my Perl is rusty, so please double check it.
FWIW Junio's pattern looks OK to me.
> The "(\S*?)" construct looks weird (you probably meant to use "(\S*)" for the
> remote name), but the rest is probably OK. I'll send the "double-checked"
> patch tomorrow unless you beat me at that.
The use of (\S+?) here is right. We want to be non-greedy in our
matching of the remote name, as we don't want to overslurp and grab
through the key name and part of the key value into the remote name
by mistake, especially if the key value contained spaces.
--
Shawn.
next prev parent reply other threads:[~2007-02-21 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 5:03 [PATCH] git-remote: support remotes with a dot in the name Pavel Roskin
2007-02-21 5:21 ` Junio C Hamano
2007-02-21 5:46 ` Pavel Roskin
2007-02-21 6:18 ` Junio C Hamano
2007-02-21 7:12 ` Pavel Roskin
2007-02-21 7:29 ` Shawn O. Pearce [this message]
2007-02-21 7:32 ` Junio C Hamano
2007-02-21 10:21 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221072921.GB28152@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.