From: "John W. Linville" <linville@tuxdriver.com>
To: Roger While <simrw@sim-basis.de>
Cc: netdev@vger.kernel.org, jeff@garzik.org, dcbw@redhat.com,
linux-wireless@vger.kernel.org
Subject: Re: [git patches] net driver updates
Date: Wed, 21 Feb 2007 08:27:54 -0500 [thread overview]
Message-ID: <20070221132754.GA4978@tuxdriver.com> (raw)
In-Reply-To: <6.1.1.1.2.20070221124144.04783fb8@192.168.6.12>
On Wed, Feb 21, 2007 at 12:46:46PM +0100, Roger While wrote:
>
> >
> >Dan Williams (1):
> > prism54: correct assignment of DOT1XENABLE in WE-19 codepaths
>
> Where did this spring from ?
> I see no posting of this patch let alone
> an ACK.
> The patch is also doing rather more than the description -
> It is inserting extra breaks into a switch statement with
> no comment as to why.
Dan posted it to linux-wireless@vger.kernel.org on 13 Feb 2007.
The description in the body is quoted below:
Correct assignment of DOT1XENABLE in WE-19 codepaths.
RX_UNENCRYPTED_EAPOL = 1 really means setting DOT1XENABLE _off_, and
vice versa. The original WE-19 patch erroneously reversed that. This
patch fixes association with unencrypted and WEP networks when using
wpa_supplicant.
It also adds two missing break statements that, left out, could result
in incorrect card configuration.
Please commit to both development and stable branches.
Hth...
John
--
John W. Linville
linville@tuxdriver.com
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Roger While <simrw-95wjJ3trAfEOIzVOb1FTxg@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org,
dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [git patches] net driver updates
Date: Wed, 21 Feb 2007 08:27:54 -0500 [thread overview]
Message-ID: <20070221132754.GA4978@tuxdriver.com> (raw)
In-Reply-To: <6.1.1.1.2.20070221124144.04783fb8-Q0ErXNX1RuZq5LbY+mFP1w@public.gmane.org>
On Wed, Feb 21, 2007 at 12:46:46PM +0100, Roger While wrote:
>
> >
> >Dan Williams (1):
> > prism54: correct assignment of DOT1XENABLE in WE-19 codepaths
>
> Where did this spring from ?
> I see no posting of this patch let alone
> an ACK.
> The patch is also doing rather more than the description -
> It is inserting extra breaks into a switch statement with
> no comment as to why.
Dan posted it to linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org on 13 Feb 2007.
The description in the body is quoted below:
Correct assignment of DOT1XENABLE in WE-19 codepaths.
RX_UNENCRYPTED_EAPOL = 1 really means setting DOT1XENABLE _off_, and
vice versa. The original WE-19 patch erroneously reversed that. This
patch fixes association with unencrypted and WEP networks when using
wpa_supplicant.
It also adds two missing break statements that, left out, could result
in incorrect card configuration.
Please commit to both development and stable branches.
Hth...
John
--
John W. Linville
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org
next prev parent reply other threads:[~2007-02-21 13:51 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 11:46 [git patches] net driver updates Roger While
2007-02-21 12:01 ` Johannes Berg
2007-02-21 13:27 ` John W. Linville [this message]
2007-02-21 13:27 ` John W. Linville
2007-02-22 15:48 ` Dan Williams
-- strict thread matches above, loose matches on Subject: below --
2008-10-27 23:18 Jeff Garzik
2008-10-28 18:10 ` David Miller
2008-08-14 9:32 Jeff Garzik
2008-08-14 21:54 ` David Miller
2008-08-07 8:50 Jeff Garzik
2008-08-07 9:19 ` David Miller
2008-08-07 10:09 ` Martin Michlmayr
2008-07-30 21:41 Jeff Garzik
2008-07-30 22:49 ` David Miller
2008-05-06 16:42 Jeff Garzik
2008-05-08 9:49 ` David Miller
2008-04-25 7:26 Jeff Garzik
2008-04-25 7:32 ` David Miller
2008-04-26 22:07 ` Ben Hutchings
2008-04-27 0:43 ` David Miller
2008-04-27 2:53 ` Jeff Garzik
2008-04-27 11:34 ` Ben Hutchings
2008-03-29 2:24 Jeff Garzik
2008-03-29 3:02 ` David Miller
2008-02-11 17:05 Jeff Garzik
2008-02-11 20:07 ` Divy Le Ray
2008-02-20 20:38 ` Jeff Garzik
2008-02-21 1:16 ` Divy Le Ray
2008-02-21 3:43 ` Krishna Kumar2
2008-02-21 5:46 ` David Miller
2008-02-21 5:57 ` Divy Le Ray
2008-02-21 6:02 ` Krishna Kumar2
2008-02-21 6:15 ` David Miller
2008-02-21 6:54 ` Divy Le Ray
2008-02-25 22:59 ` Jeff Garzik
2008-02-25 23:34 ` Marin Mitov
2008-02-25 23:36 ` Jeff Garzik
2008-02-26 20:52 ` David Miller
2008-02-26 0:13 ` Divy Le Ray
2008-02-26 0:17 ` Jeff Garzik
2008-02-12 5:57 ` David Miller
2008-02-12 12:38 ` Ben Dooks
2008-02-12 16:01 ` Jeff Garzik
2008-02-06 11:49 Jeff Garzik
2008-02-06 11:52 ` David Miller
[not found] <20080122110231.GA18441@havoc.gtf.org>
2008-01-22 14:20 ` David Miller
2007-10-25 7:49 Jeff Garzik
2007-10-24 1:30 Jeff Garzik
2007-10-15 20:19 Jeff Garzik
2007-10-10 1:03 Jeff Garzik
2007-10-10 1:12 ` David Miller
2007-10-05 18:20 Jeff Garzik
2007-10-08 6:06 ` David Miller
2007-10-03 18:39 Jeff Garzik
2007-10-03 22:33 ` David Miller
2007-10-02 17:41 Jeff Garzik
2007-10-02 23:38 ` David Miller
2007-09-29 6:08 Jeff Garzik
2007-09-20 7:26 Jeff Garzik
2007-09-20 18:42 ` David Miller
2007-07-24 20:55 Jeff Garzik
2007-07-18 23:53 Jeff Garzik
2007-07-16 22:57 Jeff Garzik
2007-07-17 8:02 ` maximilian attems
2007-07-10 18:39 Jeff Garzik
2007-07-11 9:34 ` Jiri Kosina
2007-07-11 16:28 ` Chris Stromsoe
2007-05-11 21:58 Jeff Garzik
2007-05-08 6:33 Jeff Garzik
2007-05-18 21:46 ` Mariusz Kozłowski
2007-05-18 21:54 ` Andrew Morton
2007-05-18 22:16 ` Mariusz Kozlowski
2007-05-18 22:19 ` Gene Heskett
2007-04-29 16:19 Jeff Garzik
2007-04-29 16:21 ` Christoph Hellwig
2007-02-20 18:16 Jeff Garzik
2007-02-17 22:17 Jeff Garzik
2007-02-08 0:29 Jeff Garzik
2007-02-08 6:30 ` Junio C Hamano
2007-02-08 14:30 ` Jeff Garzik
2006-12-11 15:45 Jeff Garzik
2006-12-07 12:14 Jeff Garzik
[not found] <20061002154831.GA8929@havoc.gtf.org>
2006-10-02 18:04 ` Andrew Morton
2006-09-24 16:24 Jeff Garzik
2006-07-05 18:18 Jeff Garzik
2006-06-27 3:57 Jeff Garzik
2006-05-20 4:28 Jeff Garzik
2006-05-20 16:20 ` Andrew Morton
2006-05-20 17:36 ` Linus Torvalds
2006-05-20 17:55 ` Andrew Morton
2006-05-20 22:15 ` Andi Kleen
2006-05-21 7:11 ` Manfred Spraul
2006-05-21 13:24 ` Andreas Kleen
2006-05-21 14:56 ` Manfred Spraul
2006-05-22 12:46 ` Andi Kleen
2006-03-29 23:00 Jeff Garzik
2006-03-24 17:19 Jeff Garzik
2006-03-23 1:34 Jeff Garzik
2006-03-21 21:55 Jeff Garzik
2006-03-20 11:17 Jeff Garzik
2005-09-05 22:47 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221132754.GA4978@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=dcbw@redhat.com \
--cc=jeff@garzik.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simrw@sim-basis.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.