From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, jbenc@suse.cz
Subject: Re: [RFC PATCH] d80211: fix build break from netdev class_device -> device changes
Date: Wed, 21 Feb 2007 08:32:03 -0500 [thread overview]
Message-ID: <20070221133202.GB4978@tuxdriver.com> (raw)
In-Reply-To: <1172054717.3705.1.camel@johannes.berg>
On Wed, Feb 21, 2007 at 11:45:16AM +0100, Johannes Berg wrote:
> On Tue, 2007-02-20 at 19:58 -0500, John W. Linville wrote:
> > In preparation for 2.6.21-rc1, I pulled Linus' latest tree into a
> > branch of wireless-dev. I hit a build problem with the sysfs stuff,
> > due to the recent changes from class_device -> device for net_device.
>
> Hmm, need to look up the reason and see if wiphy stuff should follow.
Exactly what I was thinking, and what made me question the patch's
completeness...
> > Since I don't count sysfs as a strength, I thought it was worth
> > posting this for some review before I actually pulled Linus' latest
> > into wireless-dev and slapped this on top of it... :-)
> >
> > Comments?
>
> Seems fine. Is to_net_dev() defined in netdevice.h now?
Ja.
> OTOH, we might want to take this opportunity and move it all to
> debugfs ;)
Excellent suggestion. But for now, I just want my tree to build and
run... :-)
Thanks for the eyeballs!
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-02-21 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 0:58 [RFC PATCH] d80211: fix build break from netdev class_device -> device changes John W. Linville
2007-02-21 10:45 ` Johannes Berg
2007-02-21 13:32 ` John W. Linville [this message]
2007-02-23 14:59 ` [RFC] convert wiphy to struct device Johannes Berg
2007-02-23 20:19 ` Greg KH
2007-02-23 20:33 ` Johannes Berg
2007-02-21 17:45 ` [RFC PATCH] d80211: fix build break from netdev class_device -> device changes Jiri Benc
2007-02-21 17:49 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221133202.GB4978@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.