From: Andrew Morton <akpm@linux-foundation.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
<linux-usb-devel@lists.sourceforge.net>,
Pete Zaitcev <zaitcev@redhat.com>, Greg KH <gregkh@suse.de>,
Kumar Gala <galak@kernel.crashing.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [linux-usb-devel] 2.6.20 kernel hang with USB drive and vfat doing ftruncate
Date: Wed, 21 Feb 2007 14:54:19 -0800 [thread overview]
Message-ID: <20070221145419.2f783dc3.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0702211644170.3435-100000@iolanthe.rowland.org>
On Wed, 21 Feb 2007 16:50:23 -0500 (EST)
Alan Stern <stern@rowland.harvard.edu> wrote:
> > + if ((gfp_mask & (__GFP_FS|__GFP_IO)) != (__GFP_FS|__GFP_IO)) {
>
> Is that really the correct test? I don't know enough about the memory
> management subsystem to say one way or the other. What's special about
> having both flags set?
yup. We're saying "if the caller is unable to take either IO locks or FS
locks, don't wait on FS or IO completion".
ie: don't wait on writeout progress unless we know that both the IO system
and the FS are able to make progress.
next prev parent reply other threads:[~2007-02-21 22:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 19:54 2.6.20 kernel hang with USB drive and vfat doing ftruncate Kumar Gala
2007-02-18 16:10 ` OGAWA Hirofumi
2007-02-19 21:58 ` Kumar Gala
2007-02-19 22:19 ` OGAWA Hirofumi
2007-02-19 22:27 ` Kumar Gala
2007-02-20 17:20 ` OGAWA Hirofumi
2007-02-19 22:06 ` Kumar Gala
2007-02-21 20:18 ` OGAWA Hirofumi
2007-02-21 20:57 ` Andrew Morton
2007-02-21 21:22 ` [linux-usb-devel] " Alan Stern
2007-02-21 21:31 ` Andrew Morton
2007-02-21 21:50 ` Alan Stern
2007-02-21 22:54 ` Andrew Morton [this message]
2007-02-22 7:40 ` Kumar Gala
2007-02-22 18:20 ` Kumar Gala
2007-02-22 21:57 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221145419.2f783dc3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=galak@kernel.crashing.org \
--cc=gregkh@suse.de \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=stern@rowland.harvard.edu \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.