From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from static-ip-62-75-166-246.inaddr.intergenia.de ([62.75.166.246]:42830 "EHLO vs166246.vserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422665AbXBUQiH (ORCPT ); Wed, 21 Feb 2007 11:38:07 -0500 From: Michael Buesch To: Ivo van Doorn Subject: Re: [PATCH 2/3] d80211: Split antenna selection into TX and RX antenna Date: Wed, 21 Feb 2007 17:37:33 +0100 Cc: Jiri Benc , "John W. Linville" , linux-wireless@vger.kernel.org References: <200702211702.47410.IvDoorn@gmail.com> In-Reply-To: <200702211702.47410.IvDoorn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200702211737.33996.mb@bu3sch.de> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wednesday 21 February 2007 17:02, Ivo van Doorn wrote: > Let broadcom use the antenna_tx field for hardware configuration. > I did not check if the device is also capable of RX antenna selection, > but current implementation only suggested support for the TX antenna. > > Signed-off-by: Ivo van Doorn > > --- > > diff --git a/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c > index cdce227..580ea33 100644 > --- a/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c > +++ b/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c > @@ -2609,7 +2609,7 @@ static int bcm43xx_dev_config(struct ieee80211_hw *hw, > int antenna = -1; > int err = 0; > > - switch (conf->antenna_sel) { > + switch (conf->antenna_sel_tx) { Nope, this is conf->antenna_sel_rx ;) -- Greetings Michael.