From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nf-out-0910.google.com ([64.233.182.187]:62524 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422668AbXBUQpD (ORCPT ); Wed, 21 Feb 2007 11:45:03 -0500 Received: by nf-out-0910.google.com with SMTP id o25so254600nfa for ; Wed, 21 Feb 2007 08:45:01 -0800 (PST) To: Michael Buesch Subject: Re: [PATCH 2/3] d80211: Split antenna selection into TX and RX antenna Date: Wed, 21 Feb 2007 17:44:23 +0100 Cc: Jiri Benc , "John W. Linville" , linux-wireless@vger.kernel.org References: <200702211702.47410.IvDoorn@gmail.com> <200702211737.33996.mb@bu3sch.de> In-Reply-To: <200702211737.33996.mb@bu3sch.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200702211744.24034.IvDoorn@gmail.com> From: Ivo van Doorn Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wednesday 21 February 2007 17:37, Michael Buesch wrote: > On Wednesday 21 February 2007 17:02, Ivo van Doorn wrote: > > Let broadcom use the antenna_tx field for hardware configuration. > > I did not check if the device is also capable of RX antenna selection, > > but current implementation only suggested support for the TX antenna. > > > > Signed-off-by: Ivo van Doorn > > > > --- > > > > diff --git a/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c > > index cdce227..580ea33 100644 > > --- a/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c > > +++ b/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c > > @@ -2609,7 +2609,7 @@ static int bcm43xx_dev_config(struct ieee80211_hw *hw, > > int antenna = -1; > > int err = 0; > > > > - switch (conf->antenna_sel) { > > + switch (conf->antenna_sel_tx) { > > Nope, this is conf->antenna_sel_rx > ;) On further inspection not even that. :P The outcome of that switch is stored in the antenna variable, which is used with bcm43xx_mgmtframe_txantenna(dev, antenna); bcm43xx_set_rx_antenna(dev, antenna); So I guess that needs to be fixed to create a switch statement for the RX antenna and one for the TX antenna? Ivo