From: Ivo van Doorn <ivdoorn@gmail.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: Jiri Benc <jbenc@suse.cz>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] d80211: Split antenna selection into TX and RX antenna
Date: Wed, 21 Feb 2007 17:52:34 +0100 [thread overview]
Message-ID: <200702211752.34498.IvDoorn@gmail.com> (raw)
In-Reply-To: <200702211751.27245.mb@bu3sch.de>
> > On further inspection not even that. :P
> > The outcome of that switch is stored in the antenna variable, which is used with
> >
> > bcm43xx_mgmtframe_txantenna(dev, antenna);
> > bcm43xx_set_rx_antenna(dev, antenna);
> >
> > So I guess that needs to be fixed to create a switch statement for
> > the RX antenna and one for the TX antenna?
>
> Ah, yeah. I didn't have the complete code for this in my head. :)
>
> I'd rather like to have a helper function
> int bcm43xx_antenna_from_ieee80211(u8 antenna)
> which includes the switch statement and use it twice in the
> config callback. Wanna do that?
No problem, I will resend this patch with that helper function added.
Ivo
next prev parent reply other threads:[~2007-02-21 16:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 16:02 [PATCH 2/3] d80211: Split antenna selection into TX and RX antenna Ivo van Doorn
2007-02-21 16:37 ` Michael Buesch
2007-02-21 16:44 ` Ivo van Doorn
2007-02-21 16:51 ` Michael Buesch
2007-02-21 16:52 ` Ivo van Doorn [this message]
2007-02-21 17:06 ` Ivo van Doorn
2007-02-21 17:19 ` Michael Buesch
2007-02-21 17:24 ` Ivo van Doorn
2007-02-21 17:32 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702211752.34498.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.