From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: linux-kernel@vger.kernel.org,
linux-fbdev-devel@lists.sourceforge.net,
linux-acpi@vger.kernel.org
Subject: ACPI: ibm-acpi: fix initial status of backlight device
Date: Wed, 21 Feb 2007 23:16:43 -0200 [thread overview]
Message-ID: <20070222011643.GB8845@khazad-dum.debian.net> (raw)
In-Reply-To: <20070222011017.GA8845@khazad-dum.debian.net>
The brightness class core does not update the initial status of
the device's brightness at register time. Do it by ourselves
before we register the class device.
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
NOTE: This patch needs an ACK from Richard Purdie before it can be merged,
as he might want to change the backlight class code instead.
drivers/acpi/ibm_acpi.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
index 2429e11..6875421 100644
--- a/drivers/acpi/ibm_acpi.c
+++ b/drivers/acpi/ibm_acpi.c
@@ -1713,6 +1713,13 @@ static struct backlight_properties ibm_backlight_data = {
static int brightness_init(void)
{
+ int b;
+
+ b = brightness_get(NULL);
+ if (b < 0)
+ return b;
+ ibm_backlight_data.brightness = b;
+
ibm_backlight_device = backlight_device_register("ibm", NULL, NULL,
&ibm_backlight_data);
if (IS_ERR(ibm_backlight_device)) {
--
1.4.4.4
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2007-02-22 1:16 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-19 4:46 no backlight on radeon after recent kernel "upgrade"s Yaroslav Halchenko
2007-02-19 8:04 ` Andrew Morton
2007-02-19 8:04 ` Andrew Morton
2007-02-19 9:19 ` Richard Purdie
2007-02-19 9:19 ` Richard Purdie
2007-02-21 5:56 ` Yaroslav Halchenko
2007-02-22 0:34 ` Richard Purdie
2007-02-22 0:34 ` Richard Purdie
2007-02-22 1:07 ` James Simmons
2007-02-22 1:07 ` James Simmons
2007-02-22 9:46 ` Richard Purdie
2007-02-22 9:46 ` Richard Purdie
2007-02-22 15:18 ` James Simmons
2007-02-22 1:11 ` [Linux-fbdev-devel] " James Simmons
2007-02-22 2:09 ` Joel Becker
2007-02-22 15:55 ` James Simmons
2007-02-22 15:55 ` [Linux-fbdev-devel] " James Simmons
2007-02-22 17:28 ` David Miller
2007-02-22 17:28 ` [Linux-fbdev-devel] " David Miller
2007-02-28 16:55 ` James Simmons
2007-03-01 10:57 ` Richard Purdie
2007-03-01 10:57 ` [Linux-fbdev-devel] " Richard Purdie
2007-03-01 21:08 ` James Simmons
2007-03-01 21:08 ` [Linux-fbdev-devel] " James Simmons
2007-02-21 22:18 ` Alex Romosan
2007-02-21 22:41 ` Richard Purdie
2007-02-21 22:41 ` Richard Purdie
2007-02-21 23:17 ` Henrique de Moraes Holschuh
2007-02-22 0:12 ` Richard Purdie
2007-02-22 0:12 ` Richard Purdie
2007-02-22 0:51 ` Henrique de Moraes Holschuh
2007-02-22 1:10 ` Richard Purdie
2007-02-22 1:10 ` Richard Purdie
2007-02-22 2:13 ` Henrique de Moraes Holschuh
2007-02-22 1:10 ` Henrique de Moraes Holschuh
2007-02-22 1:16 ` Henrique de Moraes Holschuh [this message]
2007-02-22 10:03 ` ACPI: ibm-acpi: fix initial status of backlight device Richard Purdie
2007-02-22 14:45 ` Henrique de Moraes Holschuh
2007-02-22 18:19 ` Henrique de Moraes Holschuh
2007-02-22 10:00 ` no backlight on radeon after recent kernel "upgrade"s Richard Purdie
2007-02-22 10:00 ` Richard Purdie
2007-02-22 14:56 ` Henrique de Moraes Holschuh
2007-02-22 15:19 ` Richard Purdie
2007-02-22 15:19 ` Richard Purdie
2007-02-22 16:00 ` James Simmons
2007-02-22 16:00 ` James Simmons
2007-02-22 16:34 ` Henrique de Moraes Holschuh
2007-02-22 17:08 ` Richard Purdie
2007-02-22 17:08 ` Richard Purdie
2007-02-21 23:51 ` Alex Romosan
2007-02-22 1:13 ` James Simmons
2007-02-22 1:13 ` James Simmons
2007-02-22 9:56 ` Richard Purdie
2007-02-22 9:56 ` Richard Purdie
2007-02-22 14:38 ` Henrique de Moraes Holschuh
2007-02-22 4:03 ` Alex Romosan
2007-02-22 4:58 ` Alex Romosan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070222011643.GB8845@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.