From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
john stultz <johnstul@us.ibm.com>,
Roman Zippel <zippel@linux-m68k.org>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] EXPORT_SYMBOL() time functions
Date: Thu, 22 Feb 2007 08:28:15 +0100 [thread overview]
Message-ID: <200702220828.16578.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <20070222034001.GB9027@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
Christoph Hellwig wrote:
> On Wed, Feb 21, 2007 at 02:13:38PM +0100, Rolf Eike Beer wrote:
> > These functions were inlines before
> > 8b9365d753d9870bb6451504c13570b81923228f. Now EXPORT_SYMBOL() them to
> > allow them to be used in modules again.
>
> Just because they happened to be inlined that doesn't mean modules should
> be using them. In fact no intree module uses them exactly because they're
> not intended to be used by this kind of code. Please show the code you
> want to use this for so we can see what you're really trying to do.
Trying to convert a given user value (in milliseconds) to a timeout. No
problem doing this with struct timespec.
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-02-22 7:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 13:12 [PATCH] EXPORT_SYMBOL() time functions Rolf Eike Beer
2007-02-21 13:13 ` Rolf Eike Beer
2007-02-22 3:40 ` Christoph Hellwig
2007-02-22 7:28 ` Rolf Eike Beer [this message]
2007-02-21 13:32 ` Arjan van de Ven
2007-02-21 14:23 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702220828.16578.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jeremy@goop.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.