From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Angelo P. Castellani" <angelo.castellani@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, francesco@net.infocom.uniroma1.it,
andrea.baiocchi@uniroma1.it
Subject: Re: [PATCH 1/2][TCP] YeAH-TCP: algorithm implementation
Date: Thu, 22 Feb 2007 11:36:36 -0800 [thread overview]
Message-ID: <20070222113636.28ba1896@freekitty> (raw)
In-Reply-To: <8dd26e70702220810x21c8d494u1200de1c02d23d57@mail.gmail.com>
Minor comments:
1. Please move div64_64 out of yeah-tcp (and cubic where you copied it).
to asm-generic/div64.h
2. Don't need separate tcp_yeah.h just put it in tcp_yeah.c. Also, maybe
the vegas stuff you copied should go in one place? tcp/vegas.h?
3. whitespace:
don't do:
x+=someexpression
... = max( x, ...
instead:
x += someexpression
... = max(x, ...
Using indent script in scripts/Lindent will fix these.
4. See if you can replace uses of min_t and max_t with min and max by having
proper matching types on args. Basically if you need to cast maybe original
type was wrong.
next prev parent reply other threads:[~2007-02-22 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-19 10:30 [PATCH 1/2][TCP] YeAH-TCP: algorithm implementation Angelo P. Castellani
2007-02-22 8:19 ` David Miller
2007-02-22 16:10 ` Angelo P. Castellani
2007-02-22 19:36 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-02-19 10:46 Angelo P. Castellani
2007-02-19 10:48 ` Angelo P. Castellani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070222113636.28ba1896@freekitty \
--to=shemminger@linux-foundation.org \
--cc=andrea.baiocchi@uniroma1.it \
--cc=angelo.castellani@gmail.com \
--cc=davem@davemloft.net \
--cc=francesco@net.infocom.uniroma1.it \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.