From: olof@lixom.net (Olof Johansson)
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfs: init req_lock in nfs_alloc_inode
Date: Thu, 22 Feb 2007 14:13:15 -0600 [thread overview]
Message-ID: <20070222201315.GA14686@lixom.net> (raw)
In-Reply-To: <1172018238.6421.26.camel@heimdal.trondhjem.org>
On Tue, Feb 20, 2007 at 07:37:18PM -0500, Trond Myklebust wrote:
> Looks like we need a check in nfs_getattr() for a regular file. It makes
> no sense to call nfs_sync_mapping_range() on anything else. I think that
> should fix your problem: it will stop the NFS client from interfering
> with dirty pages on that inode's mapping.
Yep, that works here. I also verified that my previous patch really
didn't change the behaviour. I wonder why it did once. Probably just
pure luck with memory contents.
> From: Trond Myklebust <Trond.Myklebust@netapp.com>
> Date: Tue, 20 Feb 2007 19:28:07 -0500
> Subject: No Subject
>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Acked-by: Olof Johansson <olof@lixom.net>
-Olof
prev parent reply other threads:[~2007-02-22 20:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 17:05 [PATCH] nfs: init req_lock in nfs_alloc_inode Olof Johansson
2007-02-17 0:15 ` Andrew Morton
2007-02-17 1:24 ` Andrew Morton
2007-02-18 20:32 ` Olof Johansson
2007-02-20 15:10 ` Trond Myklebust
2007-02-20 17:23 ` Olof Johansson
2007-02-21 0:37 ` Trond Myklebust
2007-02-22 20:13 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070222201315.GA14686@lixom.net \
--to=olof@lixom.net \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.