From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: linux-kernel-list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB Elan FTDI: check for workqueue creation
Date: Fri, 23 Feb 2007 11:10:05 +0300 [thread overview]
Message-ID: <20070223081005.GB10055@cvg> (raw)
In-Reply-To: <20070222235738.f36e534a.zaitcev@redhat.com>
On Thu, Feb 22, 2007 at 11:57:38PM -0800, Pete Zaitcev wrote:
| On Fri, 23 Feb 2007 10:53:22 +0300, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
|
| > | > -static struct workqueue_struct *status_queue;
| > | > +static struct workqueue_struct *status_queue = NULL;
|
| > | You better drop this part. Someone is bound to object.
|
| > actually I don't understand why... Event on ftdi_elan_exit()
| > status_queue is setting up to NULL. And what is bound to object?
| > Could you write more detailed?
|
| All these variables are static, they are already initialized to zero.
|
| -- Pete
|
Pete,
I may be wrong, but a lot of the kernel code have static pointers
initialized to NULL with explicit manner... More over I always thought
that _static_ is not mean _initialized to zero_. I think _static_ is
just the method to _hide_ variables in the file (as ANSI C describes).
Am I wrong?
Cyrill
next prev parent reply other threads:[~2007-02-23 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-19 18:15 [PATCH] USB Elan FTDI: check for workqueue creation Cyrill Gorcunov
2007-02-22 23:55 ` Pete Zaitcev
2007-02-23 7:53 ` Cyrill Gorcunov
[not found] ` <20070222235738.f36e534a.zaitcev@redhat.com>
2007-02-23 8:10 ` Cyrill Gorcunov [this message]
2007-02-24 1:43 ` Pete Zaitcev
2007-02-24 7:12 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070223081005.GB10055@cvg \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.