From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Tso Subject: Re: strange date generated by git-format-patch Date: Sat, 24 Feb 2007 08:08:39 -0500 Message-ID: <20070224130839.GC4380@thunk.org> References: <38d46eb0702230055i587bc775r9362aafeef803976@mail.gmail.com> <7vtzxd6y9h.fsf@assigned-by-dhcp.cox.net> <7vodnjzyvq.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Johannes Schindelin , johan defries , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Sat Feb 24 14:08:50 2007 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1HKwdt-0003fx-D3 for gcvg-git@gmane.org; Sat, 24 Feb 2007 14:08:50 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932089AbXBXNIq (ORCPT ); Sat, 24 Feb 2007 08:08:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932566AbXBXNIq (ORCPT ); Sat, 24 Feb 2007 08:08:46 -0500 Received: from thunk.org ([69.25.196.29]:34807 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932089AbXBXNIp (ORCPT ); Sat, 24 Feb 2007 08:08:45 -0500 Received: from root (helo=candygram.thunk.org) by thunker.thunk.org with local-esmtps (tls_cipher TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.50 #1 (Debian)) id 1HKwjA-0001oO-0O; Sat, 24 Feb 2007 08:14:16 -0500 Received: from tytso by candygram.thunk.org with local (Exim 4.62) (envelope-from ) id 1HKwdj-0007wS-Az; Sat, 24 Feb 2007 08:08:39 -0500 Content-Disposition: inline In-Reply-To: <7vodnjzyvq.fsf@assigned-by-dhcp.cox.net> User-Agent: Mutt/1.5.12-2006-07-14 X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: On Sat, Feb 24, 2007 at 01:30:17AM -0800, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> That is just a fake random date to make the Unix-From line recognizable > >> by common MUA and does not have anything to do with your commit objects. > > > I do not think it is worth changing it. Who's hurting with the > current behaviour? In other words, is it broken? Unix-From > lines are there only to separate each piece of e-mail in the > mbox and otherwise is not used. send-email, am, nor imap-send > should care anything beyond the leading "From ", and mailsplit > validates only that what's around the last colon near the end of > line looks like time and year. The only potential problem with it is that some MUA's (like mutt for example) sort by the From date by default. You can force it to list the patches in an unsorted order (via 'Ou'), but it might be nice if the patches date in the From field was the date that the patches were generated, with the seconds field bumped so that the patches in a series were guaranteed to have monotonically increasing dates. It's only a minor point, though. - Ted