All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: netfilter-devel@lists.netfilter.org
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>, davem@davemloft.net
Subject: [PATCH-2.4] fix missing parenthesis in unused macro in ip_nat_standalone
Date: Sun, 25 Feb 2007 09:08:54 +0100	[thread overview]
Message-ID: <20070225080854.GD25706@1wt.eu> (raw)

Hi all,

Just FYI, I've queued the following patch for 2.4.35-pre2.
Mariusz proposed to remove the unused macro (which is not
in 2.6 anymore BTW), but I don't like removing anything in
code freeze. However, fixing invalid code still seems important
to me.

Regards,
Willy

From: Willy Tarreau <w@1wt.eu>
Date: Sun, 25 Feb 2007 08:55:44 +0100
Subject: [PATCH] fix missing parenthesis in unused macro in ip_nat_standalone

The bug found by Mariusz Kozlowski affects an unused macro. However,
I prefer to fix the macro than removing it because external patches
might be relying on it.
---
 net/ipv4/netfilter/ip_nat_standalone.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/netfilter/ip_nat_standalone.c b/net/ipv4/netfilter/ip_nat_standalone.c
index 2628978..ff8935b 100644
--- a/net/ipv4/netfilter/ip_nat_standalone.c
+++ b/net/ipv4/netfilter/ip_nat_standalone.c
@@ -47,7 +47,7 @@ #define HOOKNAME(hooknum) ((hooknum) == 
 			   : ((hooknum) == NF_IP_PRE_ROUTING ? "PRE_ROUTING" \
 			      : ((hooknum) == NF_IP_LOCAL_OUT ? "LOCAL_OUT"  \
 			         : ((hooknum) == NF_IP_LOCAL_IN ? "LOCAL_IN"  \
-				    : "*ERROR*")))
+				    : "*ERROR*"))))
 
 static inline int call_expect(struct ip_conntrack *master,
 			      struct sk_buff **pskb,
-- 
1.4.2.4

                 reply	other threads:[~2007-02-25  8:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070225080854.GD25706@1wt.eu \
    --to=w@1wt.eu \
    --cc=davem@davemloft.net \
    --cc=m.kozlowski@tuxland.pl \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.