Re: exposing __attribute__ portability macros in lib.h; any objections?

[Christopher Li <sparse@chrisli.org>]

On Sun, Feb 25, 2007 at 02:45:29PM -0800, Josh Triplett wrote:
> Applied.

Thanks!

> 
> I'd also like to apply a patch to use __attribute__((__sentinel__)) on
> match_idents, which would have caught this problem.  In order to do so
> portably, I plan to add a portability macro SENTINEL_ATTR, like the
> FORMAT_ATTR macro currently in lib.h.  However, lib.h currently defines
> FORMAT_ATTR, uses it for a few prototypes, and then undefines it.  Any
> objections to defining SENTINEL_ATTR and leaving it defined (and probably
> doing the same for FORMAT_ATTR)?  I don't think those would pollute the
> namespace any more than lib.h already does with position, verbose, info, and
> similar.

No objection for __sentinel__ per se. In the long run, I would like to
get ride of match_idents completely. I want to define more parser
operation function for pre-defined keywords. So it is driven by the
symbol table rather than comparing the keyword one by one. It is a
big change though.

Chris