All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, Oleg Nesterov <oleg@tv-sign.ru>,
	Pavel Machek <pavel@ucw.cz>,
	Srivatsa Vaddagiri <vatsa@in.ibm.com>,
	Aneesh Kumar <aneesh.kumar@gmail.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Gautham R Shenoy <ego@in.ibm.com>
Subject: [RFC][PATCH 2/3] Freezer: Take kernel_execve into consideration
Date: Mon, 26 Feb 2007 11:49:09 +0100	[thread overview]
Message-ID: <200702261149.10579.rjw@sisk.pl> (raw)
In-Reply-To: <200702261139.59130.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

Kernel threads can become userland processes by calling kernel_execve().  In
particular, this may happen right after try_to_freeze_tasks(FREEZER_USER_SPACE)
has returned, so try_to_freeze_tasks() needs to take userspace processes
into consideration even if it is called with FREEZER_KERNEL_THREADS.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 kernel/power/process.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6.20-mm2/kernel/power/process.c
===================================================================
--- linux-2.6.20-mm2.orig/kernel/power/process.c	2007-02-26 08:41:18.000000000 +0100
+++ linux-2.6.20-mm2/kernel/power/process.c	2007-02-26 08:41:57.000000000 +0100
@@ -117,7 +117,7 @@ static unsigned int try_to_freeze_tasks(
 				cancel_freezing(p);
 				continue;
 			}
-			if (is_user_space(p) == !freeze_user_space)
+			if (freeze_user_space && !is_user_space(p))
 				continue;
 
 			freeze_process(p);
@@ -144,7 +144,7 @@ static unsigned int try_to_freeze_tasks(
 				TIMEOUT / HZ, todo);
 		read_lock(&tasklist_lock);
 		do_each_thread(g, p) {
-			if (is_user_space(p) == !freeze_user_space)
+			if (freeze_user_space && !is_user_space(p))
 				continue;
 
 			task_lock(p);


  parent reply	other threads:[~2007-02-26 10:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-26 10:39 [RFC][PATCH 0/3] More freezer patches Rafael J. Wysocki
2007-02-26 10:47 ` [RFC][PATCH 1/3] Freezer: Fix vfork problem Rafael J. Wysocki
2007-02-26 12:00   ` Oleg Nesterov
2007-02-26 15:14     ` Srivatsa Vaddagiri
2007-02-26 16:11       ` Oleg Nesterov
2007-02-26 18:28         ` Rafael J. Wysocki
2007-02-26 21:25           ` Oleg Nesterov
2007-02-27  0:31             ` Rafael J. Wysocki
2007-02-27  4:33               ` Aneesh Kumar
2007-02-27  4:42                 ` Srivatsa Vaddagiri
2007-02-27  8:37                 ` Oleg Nesterov
2007-02-27 21:21                   ` Rafael J. Wysocki
2007-02-27 21:53                     ` Oleg Nesterov
2007-02-28  1:23                       ` Srivatsa Vaddagiri
2007-02-28 10:57                         ` Rafael J. Wysocki
2007-02-28 11:00                           ` Oleg Nesterov
2007-02-28 19:36                             ` Rafael J. Wysocki
2007-02-28 20:30                               ` Oleg Nesterov
2007-02-28 22:34                                 ` Rafael J. Wysocki
2007-02-28 11:01                           ` Srivatsa Vaddagiri
2007-02-26 10:49 ` Rafael J. Wysocki [this message]
2007-02-26 12:45   ` [RFC][PATCH 2/3] Freezer: Take kernel_execve into consideration Pavel Machek
2007-02-26 10:52 ` [RFC][PATCH 3/3] Freezer: Prevent ___call_usermodehelper from missing freezing requests Rafael J. Wysocki
2007-02-26 11:52   ` Oleg Nesterov
2007-02-26 11:58   ` Aneesh Kumar
2007-02-26 18:30     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702261149.10579.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@osdl.org \
    --cc=aneesh.kumar@gmail.com \
    --cc=ego@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pavel@ucw.cz \
    --cc=vatsa@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.