From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Nicolas Pitre <nico@cam.org>, git@vger.kernel.org
Subject: Re: [PATCH 5/6] convert object type handling from a string to a number
Date: Tue, 27 Feb 2007 10:01:26 -0500 [thread overview]
Message-ID: <20070227150126.GA3230@spearce.org> (raw)
In-Reply-To: <7vejobhor2.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> I am wondering if "enum object_type" and signed comparison here
> are compatible. sha1_object_info() is of type "int" so that is
> clearly signed, but are we safe assuming this would not result
> in "type is unsigned and condition is always false"?
See my recent patch; I actually rewrote those hunks to use OBJ_BAD
rather than < 0, as this cleans things up for my packv4.
--
Shawn.
next prev parent reply other threads:[~2007-02-27 20:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 19:55 various cleanups Nicolas Pitre
2007-02-26 19:55 ` [PATCH 1/6] sha1_file.c: cleanup hdr usage Nicolas Pitre
2007-02-26 19:55 ` [PATCH 2/6] sha1_file.c: cleanup "offset" usage Nicolas Pitre
2007-02-26 19:55 ` [PATCH 3/6] sha1_file.c: don't ignore an error condition in sha1_loose_object_info() Nicolas Pitre
2007-02-26 19:55 ` [PATCH 4/6] formalize typename(), and add its reverse type_from_string() Nicolas Pitre
2007-02-26 19:55 ` [PATCH 5/6] convert object type handling from a string to a number Nicolas Pitre
2007-02-26 19:56 ` [PATCH 6/6] get rid of lookup_object_type() Nicolas Pitre
2007-02-27 10:35 ` [PATCH 5/6] convert object type handling from a string to a number Junio C Hamano
2007-02-27 10:53 ` Junio C Hamano
2007-02-27 14:06 ` Nicolas Pitre
2007-02-27 13:58 ` Nicolas Pitre
2007-02-27 16:24 ` Linus Torvalds
2007-02-27 17:26 ` Nicolas Pitre
2007-02-27 15:01 ` Shawn O. Pearce [this message]
2007-02-27 15:33 ` Nicolas Pitre
2007-02-27 16:07 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070227150126.GA3230@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.